Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate sample name case should be handled #50

Open
ressy opened this issue May 7, 2019 · 1 comment
Open

Duplicate sample name case should be handled #50

ressy opened this issue May 7, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
Version 0.1.0

Comments

@ressy
Copy link
Member

ressy commented May 7, 2019

The sequencers do allow a sample sheet to specify the same name for multiple samples, and currently this results in all but the first sample of a given name being "lost" during processing. How should this be handled? Based on Illumina's approach it should probably be supported, weird as it is. Maybe we should use sample number as the basis for tracking samples instead.
@ressy ressy added the bug Something isn't working label May 7, 2019
@ressy
Copy link
Member Author

ressy commented Jul 24, 2020

Still needs fixing, and using sample numbers would also sidestep the problem that the sequencer's onboard software and bcl2fastq have different naming conventions. Note that that Sample_ID in the sample sheet is not the same thing as sample number, and the output fastq.gz files appear to always be numbered sequentially.

@ressy ressy added this to the Version 0.1.0 milestone Aug 5, 2020
@ressy ressy mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.1.0
Development

No branches or pull requests
1 participant
@ressy