week 01 review - navigation structure

[jakub-c]

week-01/index.html

Lines 13 to 24 in 32e2a4e

	<section class="section-general" id="section-menu">
	<h3 id="list-header"> GET AROUND THIS DOCUMENT</h3>
	<p id="1">I. <span><a href="#profile">PROFILE</a></span></p>
	<p id="2">2.<span><a href="#experience">EXPERIENCE</a></span></p>
	<p id="3">3.<span><a href="#education">EDUCATION</a></span></p>
	<p id="4">4.<span><a href="#skills">SKILLS</a></span></p>
	<p id="5">5.<span><a href="#references">REFERENCES</a></span></p>
	<p id="6">6.<span><a href="#ArtThatILike">ARTTHATILIKE</a></span></p>
	<p id="7">7.<span><a href="#inspirational_quote">QUOTE</a></span></p>
	<p id="8">8.<span><a href="#PopulationOfCats">POPULATION OF CATS</a></span></p>
	</section>

• there was a dedicated HTML tag for navigation, I suggest you research that
• this kind on navigation is usually supposed to be created as an ordered or unordered list
• I think you should have used h2, instead of h3
• there is no need for a <span> outside those links
• I recommend you use more meaningful names for your ids - it's really hard to understand what 1,2,3,4 means

[ShazaMaher]

@jakub-c I just want to make space between the numbers and the text and I did not find any property in css to do that. I noticed a space between the number and the text that follow it. therefor I changed from ol to p tags.

so If you know any property that I can you to make dista between the number and the text in the order list please tell me about it.

[jakub-c]

@ShazaMaher this is how I would implement that part of the navigation:

<ol>
  <li><a href="#">Profile</a></li>
  <li><a href="#">Experience</a></li>
  <li><a href="#">Education</a></li>
</ol>

li {
  padding-bottom: 15px;
}

a { 
  padding-left: 15px;
  text-transform: uppercase;
}