Refactored CLI #15
Closed
Refactored CLI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved bin scripts to packages folder * Created crc32-cli package * Moved code to index.js
|
This misses the removal of CLI-only dependencies from the package.json of the crc32 package (which is the main reason for the refactoring) |
|
@garrettluu @srijonsaha what is the state of this work ? |
|
@SheetJSDev any news on this ? |
|
@SheetJSDev any chance to have this merged ? This is the last package where the CLI is not split yet IIRC. |
|
We'll split the difference: keep the bin-script but refactor to remove the dependencies. The CLI script has been added to the repo in a commit attributed to @garrettluu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue.
Moved CLI into a separate package located in
packages/crc32-cli. Published npm package here.