Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbook.DefinedName(s) support has been added. #161

Closed
wants to merge 2 commits into from
Closed

Workbook.DefinedName(s) support has been added. #161

wants to merge 2 commits into from

Conversation

alitskevich
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 83f4253 on alitskevich:master into 61b17e6 on SheetJS:master.

@SheetJSDev
Copy link
Contributor

Generally looks good, not in front of computer at the moment so I can't test just yet. Few comments:

  1. can you lift the regex definitions out of the function? if you look just above your change, wbnsregex is lifted out of parse_wb_xml so that it's processed at load time

  2. can you squash down to one commit?

  3. does make lint pass?

@alitskevich
Copy link
Contributor Author

Thank you for fast feedback (it is my very first PR on github),

  1. not sure, because call re.exec() for //g modifying re.lastIndex.
    2-3) ok, i'll check with lint and prepare a new PR tomorrow
  2. seems it also needs to add utf8read(attrValue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants