New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some files that won't convert #2
Comments
(both are clearly bugs and I'm currently testing a patch) Quick summary of what happened: In the first case (from gdocs), neither the core properties nor the worksheet dimensions were emitted by google docs (both of which I assumed were included in every xlsx workbook). The fix is to have the parser deduce the dimensions if its not provided (and to use sheet names from the workbook manifest if the properties are not provided) In the second case (from excel), there are empty cells in places like E1,F1,D2,E2,F2,... and according to the schema those cells shouldn't have been generated in the first place (in the XLS format there's a special type of cell for the cells that haven't been specified). In this case, I forced it to emit undefined (and updated sheet_to_row_object_array to ignore undefined elements) |
@nathanathan thanks a lot and keep the issues coming :) Also, can you tell me what version of excel you used for the second file? |
Thanks! |
Add syntax highlighting to readme examples
Fixes SheetJS#2 Also added a quick patch to handle unknown types
xlsx files exported from google docs seem to cause errors. I was able to convert this workbook when it was in it's original excel format.
Also, I'm getting an apparently unrelated error when I try to convert this xlsx file generated by excel.
The text was updated successfully, but these errors were encountered: