Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of console.error instead of throw #27

Closed
Sebmaster opened this issue May 18, 2013 · 1 comment
Closed

Use of console.error instead of throw #27

Sebmaster opened this issue May 18, 2013 · 1 comment

Comments

@Sebmaster
Copy link
Contributor

There are a 2 instances, where console.error is used instead of throw. I just noticed in the tests for the file with the encoded filename xlsx.js#L643 will be executed.

How severe is the error? If it's not severe: IE 6 (prob. higher too) doesn't support console(.error) AFAIK so that would throw an exception and be unuseable.
If it's severe, the user should know about it. I'd suggest euther return it in the result, or with a throw.
@redchair123
Copy link

Actually, both of them should be removed.

redchair123 added a commit that referenced this issue Oct 10, 2013
@redchair123
Removed unnecessary console.error statements
1625534 
Fixes #27

h/t Sebmaster for pointing this out
SheetJSDev added a commit that referenced this issue Dec 6, 2013
@SheetJSDev
Removed unnecessary console.error statements
dd9ac7d 
Fixes #27

h/t Sebmaster for pointing this out
SheetJSDev added a commit that referenced this issue Mar 9, 2022
@SheetJSDev
version bump 0.9.2: more formats
d273a28 
- do not consume trailing currency symbol (fixes #19 h/t @wilg)
- detect minutes following absolute hour (fixes #23 h/t @tedbeer)
- verify the miscellaneous formats (fixes #27 h/t @reviewher)
@SheetJS SheetJS locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sebmaster @redchair123