Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video not compressing below 10 mb #26

Closed
aamez opened this issue Aug 19, 2021 · 9 comments
Closed

Video not compressing below 10 mb #26

aamez opened this issue Aug 19, 2021 · 9 comments
Labels
Feature New feature or request

Comments

@aamez
Copy link

aamez commented Aug 19, 2021

Hi, first of all I appreciate your effort for making this package. Gone through your excel for video compress, can you do the compression for video below 10 mb? or else can you refer some other package for the same?

@numandev1
Copy link
Owner

@aamez you can remove this condition for android
https://github.com/Shobbak/react-native-compressor/blob/dd5c106522461005acd89d6f679c0ef2f96fdd74/android/src/main/java/com/reactnativecompressor/Video/AutoVideoCompression/AutoVideoCompression.java#L38

and remove this condition for IOS to compress video which size is 16MB
https://github.com/Shobbak/react-native-compressor/blob/dd5c106522461005acd89d6f679c0ef2f96fdd74/ios/Video/VideoCompressor.swift#L205

@numandev1
Copy link
Owner

@aamez i will add prop for this

@aamez
Copy link
Author

aamez commented Aug 19, 2021

@aamez i will add prop for this

sure thanks @nomi9995 :)

@daschaa
Copy link

daschaa commented Nov 24, 2021

@nomi9995 Was this prop added? Any updates on it?

@numandev1
Copy link
Owner

@joxw1 no, I did not add. I forgot. i will add it today

@numandev1 numandev1 added the Feature New feature or request label Nov 24, 2021
@numandev1
Copy link
Owner

@joxw1 i have added minimumFileSizeForCompress for this purpose

https://github.com/Shobbak/react-native-compressor#minimumfilesizeforcompress-number-default-16

i will release today after fixing one or two more issue

@daschaa
Copy link

daschaa commented Nov 24, 2021

@nomi9995 Thanks! Great effort! 🎉

@numandev1
Copy link
Owner

https://github.com/Shobbak/react-native-compressor#minimumfilesizeforcompress-number-default-16

just released 1.1.0 version of the compressor which has fixed this issue.

yarn add react-native-compressor@1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants