This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Jquery selectors #146
Merged
Jquery selectors #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @richgilbank |
|
are these all the jQuery collections in the file? If so this looks great! |
|
Yup. The ajax cart file is another story. Thinking about refactoring it with promises if I can find the time, and can do the styleguide fixes at the same time. |
cimocimocimo
pushed a commit
to cimocimocimo/Theia-Shopify-Theme
that referenced
this pull request
Nov 25, 2014
Jquery selectors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables that are jquery objects now use
$to differentiate themselves from other variables.timber.cache.bodyfor example, becomestimber.cache.$bodycc @mpiotrowicz