Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Clean ajaxify styles #152

Merged
merged 6 commits into from Jul 22, 2014
Merged

Clean ajaxify styles #152

merged 6 commits into from Jul 22, 2014

Conversation

cshold
Copy link
Contributor

@cshold cshold commented Jul 22, 2014

General cleaning of ajaxify cart styles

While working with a new theme, I noticed it was pretty difficult to override the ajax cart's styles. The drawer was defined with a dark colour scheme, and the modal was light. All colors were defined based on #ajaxifyModal or #ajaxifyDrawer, so overriding them was a specificity nightmare.

Ajax cart-related updates include:

  • Prefix Sass mixin (for cleanliness)
  • No more reliance on IDs for styles (except #ajaxifyCart-overlay)
  • Modal and drawer styles are now the same
    • Styles are set with minimal Sass variables, which can be updated to match a store's theme settings or custom colours
  • Removed general/unnecessary colors
  • Moved the flip button styles below general cart styles
  • Renamed some variables and mixins for less overlap and a cleaner naming convention
  • Modal's overlay colour is now based on the modal's background

Other updates include:

  • Renamed $borderColor to $colorBorder to match naming convention of other variables
  • Added a background colour theme option

cc @shopify/fed @carolineschnapp

-webkit-box-shadow: $shadow;
-moz-box-shadow: $shadow;
box-shadow: $shadow;
@mixin prefix($property, $value) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carolineschnapp
Copy link
Contributor

That is wonderful!

@dan-menard
Copy link
Member

Really nice cleanup. 👍 👍 👍

cshold added a commit that referenced this pull request Jul 22, 2014
@cshold cshold merged commit 2174102 into master Jul 22, 2014
@cshold cshold deleted the clean-ajaxify-styles branch July 22, 2014 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants