This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
v1.3.0 #80
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,36 @@ | ||
| window.timber = window.timber || {}; | ||
|
There was a problem hiding this comment. Looks like I lost the line comment after my update, but appreciate the notes. Rich, I assume this is what you meant by splitting the methods up? Cached elements are more aptly named. Will consider moving other selectors up there too, though I sometimes prefer keeping the relevant ones with their methods.. just preference there. There was a problem hiding this comment. Comments are still in the conversation view under "Show outdated diff", but yep, that's what I meant! |
||
|
|
||
| timber.cache = { | ||
| html: $('html'), | ||
| body: $('body') | ||
| } | ||
|
|
||
| timber.init = function () { | ||
| timber.cache.html.removeClass('no-js').addClass('js'); | ||
|
|
||
| // Run on load | ||
| timber.productImageSwitch(); | ||
| } | ||
|
|
||
| timber.productImageSwitch = function () { | ||
| var mainImage = $('#productPhoto img'), | ||
| thumbImages = $('#productThumbs a'), | ||
| newImage; | ||
|
|
||
| if (!thumbImages.length) { | ||
| return; | ||
| } | ||
|
|
||
| // Switch the main image with one of the thumbnails | ||
| // Note: this does not change the variant selected, just the image | ||
| thumbImages.on('click', function(e) { | ||
| e.preventDefault(); | ||
| newImage = $(this).attr('href'); | ||
| mainImage.attr({ src: newImage }); | ||
| }); | ||
| } | ||
|
|
||
| // Initialize Timber's JS on docready | ||
| $(function() { | ||
| window.timber.init(); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't work with IE8, assuming that's ok for Timber?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, just sets the border as transparent to get ready for a CSS transition so it can be ignored for IE8.