Feature/amazon mws without removing fws #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running green as they should be. One test is still failing though.
responses from AWS
invalid params response from Amazon Added more remote tests
to do is pass in the parameters we care about and the library will do the rest for us.
consistent and reliable. I think that was everything
|
|
||
| def parse_fulfillment_response(op, document) | ||
| response = {} | ||
| action = OPERATIONS[:outbound][op] |
There was a problem hiding this comment.
I'll take a look at how FWS was implemented, but I believe it's one of those Exception driven parts of the code (kinda dirty, I know).
There was a problem hiding this comment.
Yeah, it doesn't appear to do anything. I'm just going to remove all of it down to something simple
def parse_fulfillment_response(op, document)
{ :response_status => SUCCESS, :response_comment => MESSAGES[op][SUCCESS] }
end
| end | ||
|
|
||
| def fulfill(order_id, shipping_address, line_items, options = {}) | ||
| requires!(options, :order_date, :comment, :shipping_method) |
There was a problem hiding this comment.
Do we really require a comment and is that always sent from shopify?
csaunders
pushed a commit
that referenced
this pull request
May 28, 2012
…ing_fws Feature/amazon mws without removing fws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review @wisq @odorcicd