Merge pull request #3842 from /issues/1962

[Feature] Introduce `.json` asset support in theme app extensions
Shopify · May 6, 2024 · 34f7e79 · 34f7e79
2 parents 3466afd + 0ff96c7
commit 34f7e79
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/curvy-deers-wink.md b/.changeset/curvy-deers-wink.md
@@ -0,0 +1,6 @@
+---
+'@shopify/cli-kit': minor
+'@shopify/app': minor
+---
+
+Introduce `.json` support for theme app extensions
diff --git a/packages/app/src/cli/models/extensions/specifications/theme.ts b/packages/app/src/cli/models/extensions/specifications/theme.ts
@@ -42,7 +42,7 @@ const BUNDLE_SIZE_LIMIT = BUNDLE_SIZE_LIMIT_MB * megabytes
 const LIQUID_SIZE_LIMIT_KB = 500
 const LIQUID_SIZE_LIMIT = LIQUID_SIZE_LIMIT_KB * kilobytes
 
-const SUPPORTED_ASSET_EXTS = ['.jpg', '.jpeg', '.js', '.css', '.png', '.svg']
+const SUPPORTED_ASSET_EXTS = ['.jpg', '.jpeg', '.json', '.js', '.css', '.png', '.svg']
 const SUPPORTED_LOCALE_EXTS = ['.json']
 const SUPPORTED_EXTS: {[dirname: string]: FilenameValidation} = {
   assets: {

diff --git a/...cli-ruby/lib/project_types/extension/models/specification_handlers/theme_app_extension.rb b/...cli-ruby/lib/project_types/extension/models/specification_handlers/theme_app_extension.rb
@@ -16,7 +16,7 @@ class ThemeAppExtension < Default
         SUPPORTED_BUCKETS = %w(assets blocks snippets locales)
         BUNDLE_SIZE_LIMIT = 10 * 1024 * 1024 # 10MB
         LIQUID_SIZE_LIMIT = 100 * 1024 # 100kb
-        SUPPORTED_ASSET_EXTS = %w(.jpg .jpeg .js .css .png .svg)
+        SUPPORTED_ASSET_EXTS = %w(.jpg .jpeg .js .json .css .png .svg)
         SUPPORTED_LOCALE_EXTS = %w(.json)
 
         def create(directory_name, context, getting_started: false)