Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introduce .json asset support in theme app extensions #3842

Merged
merged 2 commits into from
May 6, 2024

Conversation

lukeh-shopify
Copy link
Contributor

WHY are these changes introduced?

Fixes #1962

WHAT is this pull request doing?

Adds .json asset support to theme app extensions. Another PR has already been shipped to enable this upstream

How to test your changes?

  • Create a new app with a theme app extension
  • Add a .json file in the assets folder
  • Run the app dev command
  • Notice the theme app extension is pushed as expected

Post-release steps

None

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@lukeh-shopify lukeh-shopify requested a review from a team May 2, 2024 20:59
Copy link
Contributor

github-actions bot commented May 2, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented May 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.77% (+0.01% 🔼)
6942/9673
🟡 Branches
68.71% (+0.02% 🔼)
3419/4976
🟡 Functions 71.22% 1858/2609
🟡 Lines
73.07% (+0.01% 🔼)
6543/8955

Test suite run success

1633 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from 0ff96c7

Copy link
Contributor

@jamesmengo jamesmengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will open this up for another reviewer since I haven't touched these before

@jamesmengo jamesmengo requested a review from a team May 2, 2024 23:13
@Shopify Shopify deleted a comment from jamesmengo May 3, 2024
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lukeh-shopify! Great stuff 🔥

@karreiro karreiro added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 34f7e79 May 6, 2024
@karreiro karreiro deleted the issues/1962 branch May 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for JSON file format in assets in theme app extensions
3 participants