-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add support for JSON file format in assets in theme app extensions #1962
Comments
Hi @blanklob !. Thanks for rising up this issue. I will ping my partners from @Shopify/theme-code-tools thus they can help you with this. |
Hi @blanklob, Thank you for bringing this up. I strongly agree that theme app extensions should also support JSON assets. However, this requires some changes at the platform level, as it is not limited to the Shopify CLI. I have contacted folks responsible for theme app extensions, and they also agree. Once this feature is available on the platform, I will implement the necessary changes at the CLI level and leave a heads-up here. Thank you again for raising this issue! |
Thanks understood. Keep me updated. |
I think the CLI should also be allowed Validation errors
• bundle: assets directory should only contain .jpg, .jpeg, .js, .css, .png, .svg files |
Related to this, I'm curious, if we need to add this type of input setting to our theme app extension (https://shopify.dev/docs/themes/architecture/settings/input-settings#color_scheme_group), how do we do so? Adding it in the
is leading to errors:
The docs say: |
I also want this functionality, please add it on the roadmap |
|
[Feature] Introduce `.json` asset support in theme app extensions
👋🏻 Hi @blanklob, thank you for the request! The change to allow JSON files in Theme App Extension assets directories has been merged and should be available in the next minor release (3.60).
@maruffahmed Unfortunately we don't have plans to support
@thosakwe If
@varun-batta If this is something you're still having trouble with after this feature is released, would you mind opening a separate issue for better tracking of your question? Thank you |
@lukeh-shopify Thanks for the heads up; I've now created a thread for WASM: #3893 |
@lukeh-shopify one year later lol |
slick library comes with .gif file can you also add support for gif file |
What area(s) will this request affect?
Extension
What type of change do you want to see?
New feature
Overview
Currently, we are able to develop theme app extensions with JSON files inside Assets folder in theme app extensions. However, when attempting to deploy the theme app extension via the CLI deploy command, an error is thrown due to unsupported file extensions. Even after forking the project and attempting to ignore the error and add support, the error persists.
Here is the error:
Motivation
I am trying to build a theme app extension that requires a JSON file as an asset, similar to how we currently use them in themes.
The text was updated successfully, but these errors were encountered: