Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonify customer sections #1640

Merged
merged 17 commits into from
Jul 7, 2022
Merged

Jsonify customer sections #1640

merged 17 commits into from
Jul 7, 2022

Conversation

tyleralsbury
Copy link
Contributor

@tyleralsbury tyleralsbury commented Apr 26, 2022

PR Summary:

Customer templates now allow the use of sections, including app sections.

Why are these changes introduced?

Fixes #543.

What approach did you take?

  1. Took all of the contents of the original liquid files, created new main sections out of them
  2. Changed the template files to .json
  3. Added names and translation strings for the schema cc @katycobb
  4. Added the top and bottom padding settings and fixed the CSS to use them

Other considerations

In the issue, there was some debate about which pages should or should not be JSONified. For consistency, I just did all of them. It allows the padding settings to apply to all of them, at the very least, and gives the merchant more flexibility.

Testing steps/scenarios

  • Desktop and mobile for the following pages
  • Padding settings should work as well
  • Functionality should be the same as before aside from the new padding settings
  • Sections should be useable on those pages

Pages while logged out

  • register
  • login
  • reset password
  • forgot password

Pages while logged in

  • account
  • order
  • addresses

Known issues

The email object doesn't seem to be passed into the section on the reset password template. It was accessible from within the template .liquid file and is used to display the phrase Enter a new password for [email address]. Where [email address] is the customer's email address.

This seems like a potential platform issue, but in the meanwhile could we change the phrasing to simply Enter a new password for your account or Enter a new password? cc @katycobb

Demo links

Checklist

@andrewetchen andrewetchen self-requested a review April 26, 2022 16:11
@ludoboludo ludoboludo self-requested a review April 26, 2022 18:23
ludoboludo
ludoboludo previously approved these changes Apr 26, 2022
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Didn't seem to have any issues. I wonder if we should be worried about app having access to account pages 🤷 (personal info of customers)

Otherwise I would just suggest some small name changes for clarity on files:

  • main-reset-password -> main-account-reset-password
  • main-register -> main-account-register
  • main-order -> main-account-orders
  • main-login -> main-account-login
  • main-addresses -> main-account-addresses
  • main-activate-account -> main-account-activate
  • main-account -> main-account

⚠️ And then there is that email reference to edit once Katy chimes in for the password reset.

locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Known issues

The email object doesn't seem to be passed into the section on the reset password template. It was accessible from within the template .liquid file and is used to display the phrase Enter a new password for [email address]. Where [email address] is the customer's email address.

This seems like a potential platform issue, but in the meanwhile could we change the phrasing to simply Enter a new password for your account or Enter a new password? cc @katycobb

Hey Tyler, just wanted to quickly add some context to the above since I saw the following theme-check annotation for it:

https://github.com/Shopify/dawn/pull/1640/files#annotation_3332856427

  1. [UndefinedObject] Undefined object `email` is correct and it should be: {{ 'customer.reset_password.subtext' | t: email: customer.email }}.
  2. As a test, I passed in customer.email and it still didn't show my email address.
  3. I don't think this ever displayed the customers' email address since the reset account password page serves an unauthenticated page so it will always show up as Enter a new password for ... since I'm not "logged" in. I looked at some older versions of Dawn and some of our legacy themes and verified the same results (no customer email).

And since this was a something that existed previously, it's definitely not a blocker. And to fix the theme-check annotation, we'd just have to change it to customer.email for the time being. As to why this wasn't surfaced as an annotation previously, I think it had to do with the exclusion of snippets under the UndefinedObject here: https://github.com/Shopify/dawn/pull/1640/checks?check_run_id=6178978749

@andrewetchen
Copy link
Contributor

Known issues

The email object doesn't seem to be passed into the section on the reset password template. It was accessible from within the template .liquid file and is used to display the phrase Enter a new password for [email address]. Where [email address] is the customer's email address.

This seems like a potential platform issue, but in the meanwhile could we change the phrasing to simply Enter a new password for your account or Enter a new password? cc @katycobb

Hey @katycobb 👋🏼

Re: Translations, I was just chatting with Tyler about this, we will want to change the string, Enter a new password for ... to something more generic like Tyler's suggestion above since it's potentially a platform issue as to why a customers' email address isn't showing up. Thanks Katy!

@katycobb
Copy link

Hey @katycobb 👋🏼

Re: Translations, I was just chatting with Tyler about this, we will want to change the string, Enter a new password for ... to something more generic like Tyler's suggestion above since it's potentially a platform issue as to why a customers' email address isn't showing up. Thanks Katy!

Hey Andrew, let's go with Enter a new password to keep things simple.
Question: is there a risk the customer email will suddenly start showing up here? Or will we remove the call for the customer's email altogether? Just wanna make sure if the issue is fixed we haven't created a line that doesn't make sense :)

@tyleralsbury I might need to connect with you for a bit more context re: the naming + what I should review. I'll book a quick chat with you tomorrow.

@andrewetchen
Copy link
Contributor

Hey Andrew, let's go with Enter a new password to keep things simple.

Thank you, Katy!

Question: is there a risk the customer email will suddenly start showing up here? Or will we remove the call for the customer's email altogether? Just wanna make sure if the issue is fixed we haven't created a line that doesn't make sense :)

No worries, that's a great question 😄

Once {{ email }} is removed from here, and this gets changed to: {{ 'customer.reset_password.subtext' | t }}, we won't have to worry about the customer email reappearing since that was the only place it was being used/referenced 🎉

@katycobb
Copy link

Hi @tyleralsbury, I took a look at the following templates + their section names. Some questions and notes below!

Question 1: are the template names themselves up for discussion, or are these already pretty established? If they're up for discussion, I'd suggest applying all the noun-ifying updates to the template names where noted for section names. So Customer register --> Customer registration for example.

Question 2: Would it be plausible to put all these customer templates under one templates folder in the editor, like how "Pages" is organized currently? TBD exactly what that could be called, but just thinking we could call it something customer-related, then remove "Customer" from the name of all the templates to reduce some redundancy. No idea what the implications of this would be, so let me know if it's a wild idea!

Register

  • Update section name Register to Registration. All our existing sections use nouns as names, rather than verbs. Updating to keep this consistent/predictable for merchants.

Reset password

  • Update section name Reset password to Password reset to make it a noun rather than a verb.

Forgot password

  • I can't seem to track this one down. Should it appear as its own template?

Order

  • I wasn't able to figure out how to see this in the editor. Does this display the details of a single order, or the customer's order history? Essentially wondering if the section should be called Order (singular) or Orders (plural)

Activate account

  • This one wasn't on your list in the PR summary but does appear in the templates list so I looked at it.
  • Update section name Activate account to Account activation to make it a noun rather than a verb.

Account

  • all good

Login

  • all good

Addresses

  • all good

@bacounts
Copy link

bacounts commented Apr 28, 2022

@tyleralsbury - see #1630 and #1631

@tyleralsbury
Copy link
Contributor Author

Question 1: are the template names themselves up for discussion, or are these already pretty established? If they're up for discussion, I'd suggest applying all the noun-ifying updates to the template names where noted for section names. So Customer register --> Customer registration for example.

They are already established. We could see with the editor team whether or not they can be changed, but they aren't defined in the theme itself.

@tyleralsbury
Copy link
Contributor Author

Question 2: Would it be plausible to put all these customer templates under one templates folder in the editor, like how "Pages" is organized currently? TBD exactly what that could be called, but just thinking we could call it something customer-related, then remove "Customer" from the name of all the templates to reduce some redundancy. No idea what the implications of this would be, so let me know if it's a wild idea!

Could be interesting - this would also be to discuss w/ the editor folks.

@tyleralsbury
Copy link
Contributor Author

I can't seem to track this one down. Should it appear as its own template?

My mistake - this is actually not a specific template. Can ignore.

@tyleralsbury
Copy link
Contributor Author

I wasn't able to figure out how to see this in the editor. Does this display the details of a single order, or the customer's order history? Essentially wondering if the section should be called Order (singular) or Orders (plural)

This one is a single order, so Order it is!

Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to remove email from {{ 'customer.reset_password.subtext' | t: email: email }} 🤔

andrewetchen
andrewetchen previously approved these changes May 13, 2022
Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks Tyler. This is definitely going to add more flexibility 🎉

ludoboludo
ludoboludo previously approved these changes May 13, 2022
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bacounts
Copy link

bacounts commented May 13, 2022

@tyleralsbury — There is still an issue with the Customer Order page as outlined in #1631 - The password field should be visable to allow the user to log in through the Editor.

To Replicate:
In the Editor > Others > Customer order

Screen Shot 2022-05-13 at 11 59 31 AM

@tyleralsbury
Copy link
Contributor Author

@tyleralsbury — There is still an issue with the Customer Order page as outlined in #1631 - The password field should be visable to allow the user to log in through the Editor.

To Replicate: In the Editor > Others > Customer order

Screen Shot 2022-05-13 at 11 59 31 AM

Thanks @bacounts . We will investigate this separately - it may be a platform issue with the redirect that happens when Customer Order is selected when there is no customer logged in in the editor.

@melissaperreault
Copy link
Contributor

Note for the UX reviewer

Please take note of all the edge cases and areas the global styles don't apply well and opportunities. Open new issues as they come and ping me on slack so we can talk through them! 🙏

@Oliviammarcello Oliviammarcello self-requested a review May 16, 2022 17:54
@Oliviammarcello
Copy link
Contributor

This is looking great!

  • There seems to be extra padding above the heading text on all the customer pages. Example | Current

Otherwise, I think it all works as expected 🎉

andrewetchen
andrewetchen previously approved these changes May 18, 2022
Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking good 🎉

@ludoboludo
Copy link
Contributor

Looks like we will hold on to merging this PR until next week when can run a couple test to make sure nothing breaks with those changes. 👍

@ludoboludo ludoboludo dismissed stale reviews from andrewetchen and themself via d6065f2 June 27, 2022 21:43
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re approving, I had just rebased from main.

@andrewetchen, I'll need your re approval in order to merge the PR 🙂 I tested with Martina to make sure it wouldn't break anything during a manual update for a merchant's theme 👍

Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving as this looks good to me 🎉

@ludoboludo ludoboludo merged commit 627bb72 into main Jul 7, 2022
@ludoboludo ludoboludo deleted the jsonify-customer-sections branch July 7, 2022 19:43
TimmersThomas pushed a commit to TimmersThomas/shopify-template-houseofchocolate that referenced this pull request Aug 29, 2022
JonoHall added a commit to ResinCraft/dawn that referenced this pull request Nov 12, 2022
* Add "Maximum Products to Show" setting to Product Recommendations section (Shopify#1429)

* Add missing gradient support (Shopify#1304)

* Add missing gradients to cards

* Enforce solid bg on quantity input

* Add gradient to cart notification

* Add to nav, img banner, facets, slideshow, etc

* Add to media modal

* Add to submenu

* Remove search popup gradient

* Fix mobile facets scrolling/background

* Adjust mobile nav gradients

* Cleanup

* fix border radius on combination inputs

* Fix password page email signup input (Shopify#1421)

* Setup theme-check GitHub annotations (Shopify#1422)

* test something real quick (Shopify#1467)

* Cleanup product media grid spacing (Shopify#1444)

* Cleanup product media grid

* Adjust grid selectors

* Hopefully fix arrow alignment

* Fix non-stacked item widths

* Update color list order and simplify section string (Shopify#1413)

* update color list order

* change announcement bar string

* fix label

* update collapsible content

* update email signup banner

* update footer

* update header

* update image banner

* update image with text

* update password header and footer

* update email signup

* update rich text and slideshow

* update missing translations

* Update 20 translation files

* Update sections/announcement-bar.liquid

Co-authored-by: Ludo <ludo.segura@shopify.com>

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add mega menu (Shopify#1316)

* Simplify header dropdown menu CSS selectors

* Create popup utility class to apply popup global settings styles

* Add mega menu settings to header section. Add en locale. Add mega menu liquid as snippet. Add mega menu css

* Fix indent

* Add info to menu type setting

* Remove condition for showing dropdown menus for subcategories with no children

* Force zero border-radius and top/bottom border for mega menu container since it's full width

* Update 1 translation file

* Prevent mega menu shadows from overlapping header by reducing menu content z-index. Clean up unused CSS

* Add todo

* Show mega menu top border only if header does not have separator line enabled

* Remove empty line

* Update 16 translation files

* Update 3 translation files

* Remove mega menu snippet since contents are not being re-used. Add mega menu liquid in header directly instead

* Update assets/component-mega-menu.css

Co-authored-by: MM <martina.marien@shopify.com>

* Rename utility class

* Add mega menu content layout and styles (Shopify#1338)

* Add grid for mega menu content and styles for links

* Remove role="list" from ul elements since list is ul elements' default role

* Adjust link styles

* Set mega menu content max height based on viewport height. Use header bottom position set in JS for calculation

* Round position value down instead of up to be more consistent with other instances where --header-bottom-position value is set in JS

* Fix spacing

* Change level 2 link color to better distinguish from level 3 links

* Revert mega menu heading opacity to improve color contrast

* Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into add-mega-menu-content

# Conflicts:
#	snippets/mega-menu.liquid

* Add id to mega menu content container (JS will use id to add aria-control attribute to summary element). Add role="list" to ul in mega menu for a11y (when list bullets are removed some assistive technologies may not convey ul as list without explicit role)

* Fix typo

* Combine css properties for same class

* Set mega menu links to display block to ensure bigger touch target

* Add some bottom offset to menu max-height to prevent iOS Safari from cutting off bottom of menu

* Update link style (remove uppercase) for 2nd level links that have no children

* Update L2 link font to bold. Use Liquid to calculate bold font-weight value: "bold" will be +300 relative to default body font-weight, but restricted to max of 1000

* Address feedback. Add explicit role="list" for a11y (when list bullets are removed some assistive technologies may not convey ul as list without explicit role)

* Use rem instead of px

* Remove redundant css

* Update line height to account for body scale

* Move JS to set header bottom position CSS variable to its own custom HTML component. This is to ensure this snippet of JS does not run if not needed

* Remove usage of --viewport-height since its value may not have been set

* Update references (in JS and CSS) to details-disclosure to also account for header-menu which extends details-disclosure

* Update logic to set  --header-bottom-position-desktop value when menu is toggled, instead of in constructor. This ensures the header is visible when the value is calculated

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: MM <martina.marien@shopify.com>

* Update translations: merchant (Shopify#1474)

* Update 1 translation file (Shopify#1475)

* Center align payment terms form text when there is no image (Shopify#1473)

* Add grid settings to collections list (Shopify#1469)

* Feat. collection updates (Shopify#1295)

* Update 20 translation files (Shopify#1487)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Theme check manual fixes (Shopify#1379)

* Clean up behaviour when there are only L2 links mega menu (Shopify#1492)

* Center mega menu (Shopify#1482)

* Update 1 translation file (Shopify#1499)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Video alt text info content update (Shopify#935)

* Video alt text info content update

* Update locales/en.default.schema.json

* Update locales/en.default.schema.json

* Update 4 translation files

* Update 3 translation files

* Update 9 translation files

* Update 3 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Adjust color contrast for Vendor on the cart page (Shopify#1462)

* Add support for boolean filters (Shopify#1456)

* Fixed condensed mega menu (Shopify#1504)

* Fixed condensed mega menu

* Fixed bug where product page thumbnail slider arrows were appearing when they shouldnt (Shopify#1510)

* Fixed multicolumn gap spacing on mobile (Shopify#1505)

* Fixed multicolumn gap spacing on mobile

* Fixed max price display on filter drawer (Shopify#1512)

* Theme check TemplateLength (Shopify#1511)

* Add PR checkbox for theme documentation (Shopify#1516)

* Add PR checkbox for theme documentation

* Update .github/PULL_REQUEST_TEMPLATE.md

* Update 1 translation file (Shopify#1517)

* Update 1 translation file (Shopify#1528)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1533)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1536)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Quick Add (Shopify#1388)

* Featured Collection : Fix max width setting (Shopify#1538)

* Fix product rating help doc links (Shopify#1532)

* fix links for product rating

* Update 20 translation files

* update os2 links and remove /en

* update other URL to remove the language path

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Prevent empty heading in contact form (Shopify#1515)

* Only render contact heading if not empty

* Add fallback form heading

* Move title string

* Update 21 translation files

* Update 3 translation files

* Update 6 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Move slideshow control buttons when set to autorotate (Shopify#1523)

* Update 1 translation file (Shopify#1554)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Hide inactive mobile menu items from screen readers (Shopify#1493)

* Hide mobile menu ancestors from screen readers

* Account for close button

* Cleanup on drawer close

* Account for mobile facets drawer

* Vertical filter (Shopify#1443)

* Remove transforms from image with text content (Shopify#1560)

* Fix shop link on giftcard page (Shopify#1557)

Co-authored-by: Max@SMAKK <max-smakk@MacBook-Pro-4.local>

* Using font size and spacing for mega menu hierarchy (Shopify#1520)

* Using font size and spacing for mega menu hierarchy

Co-authored-by: LucasLacerdaUX <lucas.lacerda@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update translations: buyer (Shopify#1581)

* Update 1 translation file

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Quick Add: Fix button overflow on mobile carousel (Shopify#1567)

* Update spacing (Shopify#1588)

* Vertical filter UX follow ups (Shopify#1568)

* Vertical filter follow ups

* Fix button alignment

* Fix search sort

* Fix sort

* Fix wrapping

* Fix overflow

* Fix empty space

* Fix button no js

* Fix button style

* Fix filter column

* Apply secondary style

* Apply button

* Fix search

* Fix no-js layout for drawer and product count position (Shopify#1572)

* fix no-js layout for drawer and product count position

* udpate vertical product count position on drawer on desktop

* fix broken html

* remove unnecessary facets class

* update some logic to fix state after rebase

* fix spacing

* Update margin formatting

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update padding formatting

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add hidden inputs to preserve search queries (Shopify#1585)

* fix no-js layout for drawer and product count position

* udpate vertical product count position on drawer on desktop

* fix broken html

* remove unnecessary facets class

* update some logic to fix state after rebase

* fix spacing

* Add hidden inputs to preserve search queries

Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Version bump v5.0.0 (Shopify#1624)

* Remove unused setting (Shopify#1617)

* Update 5 translation files (Shopify#1626)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1634)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Remove recaptcha visibility hidden on contact form (Shopify#1637)

* Fix Product strucure-data markup for Brand property (Shopify#1600)

* Fix empty collection links (Shopify#1639)

* Fix first image lazy load on main product section (Shopify#1286)

* Make sure first image is not lazy loaded

* Use a single liquid tag

* Update sections/main-product.liquid

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

* replace the hex code by currentColor (Shopify#1591)

* Cart drawer (Shopify#1544)

* Fix button spinner in Safari (Shopify#1646)

* Rich text improvements (Shopify#1635)

* [Header] add setting to tweak top and bottom padding (Shopify#1654)

* Add header padding setting

* Update minimum to 5

* Changed defaults

* Update header with option 2

* Remove unnecessary code

* Update translations: buyer (Shopify#1659)

* Update translations: merchant (Shopify#1681)

* Remove gradient when slide container is set to be hidden on desktop (Shopify#1643)

* Revert flex grow on collage card__content (Shopify#1662)

* Update minimum header padding to zero (Shopify#1688)

* Fix a typo in main-product.liquid (Shopify#1647)

* 1-click Quick Add for products with 1 non-default variant (Shopify#1610)

* Add 1-click quick-add support for products with exactly 1 non-default variant

* Revert "Add 1-click quick-add support for products with exactly 1 non-default variant"

This reverts commit 41648ca.

* Add 1-click quick-add support for products with exactly 1 non-default variant

* Switch to Variants Size

* Update spacing below product media (Shopify#1689)

* Update spacing below product media

* Update visible

* Remove extra spacing

* Update desktop layout

* Revert button type and button 1 ids (Shopify#1705)

* Update Banner image and logo Image to use `image_tag` (Shopify#1701)

* Fix product media slider peek (Shopify#1696)

* Account for gap spacing in product slider width

* Prevent slider arrows with single media

* Remove alt text to improve screen reader experience  (Shopify#1679)

* Update Subtotal header for a11y (Shopify#1680)

* Remove extra whitespace on Quick Add modals (Shopify#1706)

* Always centered

* Non centered

* Revert height

* Set height to initial height

* Revert fixed height

* Remove extra

* Update 1 translation file (Shopify#1715)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Collapsible content] Add vertical padding to blocks (Shopify#1655)

* Fix padding. top and bottom now gets 1.5rem

* Set padding-top to 0

* Fix syntax error caused by missing calc in product CSS (Shopify#1703)

* Update 1 translation file (Shopify#1739)

* Cart drawer section fix (Shopify#1742)

* Update translations: merchant (Shopify#1757)

* Version bump v6.0.0 (Shopify#1769)

* Version bump

Update theme version to v6.0.0

* Update release-notes.md

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update release-notes.md

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Fix box shadow being cut off on sliders (Shopify#1772)

* Update contact-form.liquid (Shopify#1716)

* Update main-cart-items.liquid (Shopify#1717)

* Update main-collection-banner.liquid (Shopify#1718)

* Remove menu title requirement (Shopify#1763)

* Menu heading

Remove requirement for menu heading in footer to display

* Update footer.liquid

* Remove helper text

* Remove translations

* Update footer

* Update footer

* Update footer

* Update footer

* Revert changes

* Fixes

* Update

* Update to footer

* Badge padding update (Shopify#1785)

* Add video button aria label  (Shopify#1728)

* Change aria for active pagination nav control (Shopify#1727)

* Update 1 translation file (Shopify#1809)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Warn users that link opens in a new window (Shopify#1735)

* Add unique ids to card-product.liquid headings and product state badges (Shopify#1731)

* Badge product card position copy update (Shopify#1795)

* Badge product card position copy update

* Update 7 translation files

* Update 3 translation files

* Update 6 translation files

* Update 3 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Distinct View All IDs for screen readers (Shopify#1733)

* Fix Quick Add when cart type is set to Page (remove data-cart-type) (Shopify#1817)

* Replaced a missing </div> tag in main-search.liquid (Shopify#1804)

* version bump to 6.0.2 (Shopify#1819)

* Add help text to the Variant Pills settings area (Shopify#1782)

* Add help text to the Variant Pills settings section.

* Update copy as per reviews.

* Update 5 translation files

* Update 4 translation files

* Update 8 translation files

* Update 2 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update translations: buyer (Shopify#1828)

* Update 1 translation file

* Update locales/th.json

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update translations: merchant (Shopify#1818)

* Update 1 translation file

* Update 1 translation file

* Update 1 translation file

* Update locales/th.schema.json

* Update 1 translation file

* Update th.schema.json

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Remove duplicate .hidden class in base.css (Shopify#1811)

* Setting border-top to 0.1rem to match with header navigation (Shopify#1802)

updating component-facets.css to match div line width from the header

* Add period to Cart global setting info text (Shopify#1751)

* add period to info text

* Update 1 translation file

* Update 9 translation files

* Update 9 translation files

* Update 1 translation file

Co-authored-by: Melissa Perreault <melissaperreault@Melissas-MacBook-Pro.local>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add focus ring/border in Windows High Contrast mode (Shopify#1729)

* Update 1 translation file (Shopify#1836)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Announcment alignment (Shopify#1770)

* Announcement and translation

* Alignment for announcement bar

* Translations

* Update alignment and order of options.

* Update locales/th.schema.json

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

* Uniform padding with link

* Make colour go full width

* Full width hover and justify text

* Update sections/announcement-bar.liquid

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Remove justify

* Remove justify

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add pagination to main collection list (Shopify#1745)

* Jsonify customer sections (Shopify#1640)

* Update translations: merchant (Shopify#1843)

* Update 20 translation files

* Update 1 translation file

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1849)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update PULL_REQUEST_TEMPLATE.md

* Remove CLA from probot and use new GitHub action (Shopify#1859)

* Update 1 translation file (Shopify#1862)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add `reopened` activity type (Shopify#1874)

* add vendor to popup notification when vendor checkbox is checked (Shopify#1870)

* Add proper product title to data-shopify-title (Shopify#1858)

* Update 1 translation file (Shopify#1872)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Use param_name instead of label to construct an id for filter values (Shopify#839)

* Fix linting issues in feature-product and main-product sections (Shopify#1873)

* fix linting issues in feature-product and main-product sections

* use button--secondary when dynamic checkout or subscriptions enabled (Shopify#1875)

* [Card Settings] Break card global settings into Blog, Collection and Product Cards (Shopify#1774)

* [Header] New logo position (Shopify#1864)

* update predictive search container width (Shopify#1878)

* update predictive search container width on small screens

* Update 20 translation files (Shopify#1891)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix filter bug to allow filters to be removed (Shopify#1890)

* [Product layout] Add desktop media position (Shopify#1720)

* Update 2 translation files (Shopify#1896)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Switch blog header img to eager instead of lazy load (Shopify#1894)

* Update 1 translation file (Shopify#1899)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* fix(sections/header): remove duplicated classnames (Shopify#1853)

* change done in pickup availability (Shopify#1831)

* Fix spaces in menu IDs by replacing titles with handles (Shopify#1846)

* Increase left and top edge for zoom-icon element (Shopify#1902)

* Increase left and top edge for zoom-icon element

* Minor changes that I forgot undo

* Delete unnecessary whitespace

* Change left and top edges to 1.2rem

* fix: drawer - typing in quantity and pressing enter empties cart (Shopify#1881)

* hide quick add button when javascript is disabled (Shopify#1904)

* hide quick add button when javascript disabled

* Update PULL_REQUEST_TEMPLATE.md (Shopify#1892)

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

Adding hidden markdown

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: MM <martina.marien@shopify.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Apply suggestions from code review

* Update .github/PULL_REQUEST_TEMPLATE.md

* Edit based on feedback

Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update Lighthouse CI (Shopify#1898)

* Update card style default for collage (Shopify#1922)

* Update 1 translation file (Shopify#1924)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update PULL_REQUEST_TEMPLATE.md to include visual change reference (Shopify#1923)

* Update PULL_REQUEST_TEMPLATE.md

* Change bold to heading markup

* Fix slider padding and whitespace issue on Safari (Shopify#1669)

* Update 1 translation file (Shopify#1928)

* Add a max width to iframes within the product info container (Shopify#1929)

* Fix popup cart notification overlap in the latest Safari version (Shopify#1912)

* Fix video controls on the feat product section (Shopify#1940)

* Update 1 translation file (Shopify#1948)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1949)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1951)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Product page] Add 2 column layout for desktop and mobile (Shopify#1766)

* Android menu drawer account fix (Shopify#1945)

* Fix android menu drawer not showing account

* remove unnecessary code

* Update 8 translation files (Shopify#1956)

* Use image tag (Shopify#1906)

* image_tag in collage

* image_tag in multicolumn

* image_tag in slideshow

* image_tag in image_with_text

* image_tag in collapsible-content

* image_tag in video

* Apply suggestions from code review

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* PR review: Clean up whitespace on capture def

Co-authored-by: Kyle Conrad <kcomrade53@gmail.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
Co-authored-by: Kyle Conrad <kyle.conrad@shopify.com>

* Complementary products (Shopify#1938)

* Update translations: buyer (Shopify#1963)

* Update 29 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix shadow being cut on featured collection slider, featured blog slider and collection list slider (Shopify#1961)

* Fix shadow being cut on feat collection slider

* Missing commit

* Remove file

* Rename

* Add class

* Remove Product Subtitle block from Featured Product section (Shopify#1964)

* Remove Text Block for Product Subtitle on Dawn's pre-configured Product Page and Featured Collection sections

* Remove caption from block order

* Revert change for json templates

* [Complementary product] Keep text alignment to the left for horizontal cards (Shopify#1965)

* Keep text alignment to the left for horizontal cards

* prevent image padding from global product cards settings to apply

* Update version and release notes (Shopify#1966)

* fix margin-top on middle center header option (Shopify#1970)

* Update 1 translation file (Shopify#1967)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* fix slider controls showing in certain scenarios on mobile (Shopify#1973)

* fix closing element (Shopify#1981)

* Variant media modal fix (Shopify#1985)

* Fix duplicate class attr issue

* Prevent use of lazy_load variable in complementary block

* Ensure complementary block loads card css (Shopify#1991)

* [Complementary block] update url from the info text to the latest (Shopify#1974)

* update url from the info text to the latest

* fix parentheses

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add version bump and release notes (Shopify#1997)

* Enable language/country selector by default (Shopify#1988)

* Fetch the header (LCP) image at high priority (Shopify#1918)

* [Product page] "Icon with text" block (Shopify#1933)

Add a new Icon-With-Text block to Product Page

* Add shopify attributes to description block on product page (Shopify#2005)

* Add variant picker sold out UI [temporary solution] (Shopify#1407)

* Move product media gallery and modal into snippets [Refactor] (Shopify#1934)

* Move product media gallery and modal into snippets

* Gallery snippet api adjustments

* Fixes for featured product flexibility

* Exclude media_size from gallery api

* Update 1 translation file (Shopify#2023)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Remove setting for variant styling (Shopify#2025)

* Remove setting for variant styling

* wrong edit fix

* Update 30 translation files (Shopify#2026)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Minor improvements to product media liquid [Refactor] (Shopify#2022)

* Refactor ratio usage in product thumbnail

* Fix zoom icon placement and featured product issues

* Minor updates

* Prevent ui changes from variant selection queues (Shopify#2030)

* Prevent hidden Variant Picker block from breaking Quick Add (Shopify#2049)

* Fix 'Cannot read properties of null' error in SliderComponent (Shopify#2053)

* remove redundant role from SVGs (Shopify#2037)

* remove redundant role from SVGs

* hide icons from screen readers

* Fix z-index issue for mega menu in Safari (Shopify#2034)

* Fix z-index issue for mega menu in Safari

* add comment with context

* small edits

* change approach

* [PDP] Add SKU block (Shopify#1987)

Add SKU block to PDP

* Adjust mobile media selectors for new product-thumbnail markup (Shopify#2050)

* Add zoom flexibility (Shopify#1983)

add 'lightbox', 'hover', and 'none' zoom settings to images

* Prevent media background on deferred-media container (Shopify#2068)

* Add Inventory status block (Shopify#1979)

* [Product page & feat. product] Fix unavailable variant issue (Shopify#2031)

* Reset to default

* Reset files

* Reset changes

Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com>
Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Co-authored-by: Charles-Philippe Clermont <cp.clermont@shopify.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Talia Harrison-Marcassa <taliahm@users.noreply.github.com>
Co-authored-by: Caroline <mllegeorgesand@gmail.com>
Co-authored-by: Tyler Alsbury <60230011+tyleralsbury@users.noreply.github.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
Co-authored-by: Maximilian Bredow <30573532+bredowmax@users.noreply.github.com>
Co-authored-by: Max@SMAKK <max-smakk@MacBook-Pro-4.local>
Co-authored-by: LucasLacerdaUX <lucas.lacerda@shopify.com>
Co-authored-by: Antonio J <antonio.jhun62@gmail.com>
Co-authored-by: Baldur Helgason <baldur.helgason@gmail.com>
Co-authored-by: Alexander <alex@inso.codes>
Co-authored-by: Lee Siong Chan <leesiongchan@users.noreply.github.com>
Co-authored-by: Peretz Cohen <pizzaz93@users.noreply.github.com>
Co-authored-by: boltgolt <boltgolt@gmail.com>
Co-authored-by: Alistair Lane <alistair.lane@shopify.com>
Co-authored-by: Oliviammarcello <60230008+Oliviammarcello@users.noreply.github.com>
Co-authored-by: James <james@thoughtandmortar.com>
Co-authored-by: Kjell Reigstad <1202812+kjellr@users.noreply.github.com>
Co-authored-by: Gage <ItsGageHolland@gmail.com>
Co-authored-by: Daniel Nieuwenhuizen <danielvan@gmail.com>
Co-authored-by: Melissa Perreault <melissaperreault@Melissas-MacBook-Pro.local>
Co-authored-by: Yevhenii Huselietov <d46k16@gmail.com>
Co-authored-by: Monica Mateiu <monica.mateiu@gmail.com>
Co-authored-by: Monica Mateiu <monica.mateiu@shopify.com>
Co-authored-by: Sia <siakaramalegos@gmail.com>
Co-authored-by: Kasper Andersson <KasperAndersson@users.noreply.github.com>
Co-authored-by: Muhammad Abdullah <76752572+dexter845@users.noreply.github.com>
Co-authored-by: Nathan Dawson <n_dawson@me.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Robert <treboryx@gmail.com>
Co-authored-by: Tyler Rowsell <tyler.rowsell@shopify.com>
Co-authored-by: Kyle Conrad <kcomrade53@gmail.com>
Co-authored-by: Kyle Conrad <kyle.conrad@shopify.com>
Co-authored-by: Lucas Kim <s.lucas.kim@gmail.com>
Co-authored-by: Sia <sia.karamalegos@shopify.com>
Co-authored-by: CFX <cfxd@users.noreply.github.com>
JonoHall added a commit to ResinCraft/dawn that referenced this pull request Nov 12, 2022
* Add "Maximum Products to Show" setting to Product Recommendations section (Shopify#1429)

* Add missing gradient support (Shopify#1304)

* Add missing gradients to cards

* Enforce solid bg on quantity input

* Add gradient to cart notification

* Add to nav, img banner, facets, slideshow, etc

* Add to media modal

* Add to submenu

* Remove search popup gradient

* Fix mobile facets scrolling/background

* Adjust mobile nav gradients

* Cleanup

* fix border radius on combination inputs

* Fix password page email signup input (Shopify#1421)

* Setup theme-check GitHub annotations (Shopify#1422)

* test something real quick (Shopify#1467)

* Cleanup product media grid spacing (Shopify#1444)

* Cleanup product media grid

* Adjust grid selectors

* Hopefully fix arrow alignment

* Fix non-stacked item widths

* Update color list order and simplify section string (Shopify#1413)

* update color list order

* change announcement bar string

* fix label

* update collapsible content

* update email signup banner

* update footer

* update header

* update image banner

* update image with text

* update password header and footer

* update email signup

* update rich text and slideshow

* update missing translations

* Update 20 translation files

* Update sections/announcement-bar.liquid

Co-authored-by: Ludo <ludo.segura@shopify.com>

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add mega menu (Shopify#1316)

* Simplify header dropdown menu CSS selectors

* Create popup utility class to apply popup global settings styles

* Add mega menu settings to header section. Add en locale. Add mega menu liquid as snippet. Add mega menu css

* Fix indent

* Add info to menu type setting

* Remove condition for showing dropdown menus for subcategories with no children

* Force zero border-radius and top/bottom border for mega menu container since it's full width

* Update 1 translation file

* Prevent mega menu shadows from overlapping header by reducing menu content z-index. Clean up unused CSS

* Add todo

* Show mega menu top border only if header does not have separator line enabled

* Remove empty line

* Update 16 translation files

* Update 3 translation files

* Remove mega menu snippet since contents are not being re-used. Add mega menu liquid in header directly instead

* Update assets/component-mega-menu.css

Co-authored-by: MM <martina.marien@shopify.com>

* Rename utility class

* Add mega menu content layout and styles (Shopify#1338)

* Add grid for mega menu content and styles for links

* Remove role="list" from ul elements since list is ul elements' default role

* Adjust link styles

* Set mega menu content max height based on viewport height. Use header bottom position set in JS for calculation

* Round position value down instead of up to be more consistent with other instances where --header-bottom-position value is set in JS

* Fix spacing

* Change level 2 link color to better distinguish from level 3 links

* Revert mega menu heading opacity to improve color contrast

* Merge branch 'add-mega-menu' of https://github.com/Shopify/dawn into add-mega-menu-content

# Conflicts:
#	snippets/mega-menu.liquid

* Add id to mega menu content container (JS will use id to add aria-control attribute to summary element). Add role="list" to ul in mega menu for a11y (when list bullets are removed some assistive technologies may not convey ul as list without explicit role)

* Fix typo

* Combine css properties for same class

* Set mega menu links to display block to ensure bigger touch target

* Add some bottom offset to menu max-height to prevent iOS Safari from cutting off bottom of menu

* Update link style (remove uppercase) for 2nd level links that have no children

* Update L2 link font to bold. Use Liquid to calculate bold font-weight value: "bold" will be +300 relative to default body font-weight, but restricted to max of 1000

* Address feedback. Add explicit role="list" for a11y (when list bullets are removed some assistive technologies may not convey ul as list without explicit role)

* Use rem instead of px

* Remove redundant css

* Update line height to account for body scale

* Move JS to set header bottom position CSS variable to its own custom HTML component. This is to ensure this snippet of JS does not run if not needed

* Remove usage of --viewport-height since its value may not have been set

* Update references (in JS and CSS) to details-disclosure to also account for header-menu which extends details-disclosure

* Update logic to set  --header-bottom-position-desktop value when menu is toggled, instead of in constructor. This ensures the header is visible when the value is calculated

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: MM <martina.marien@shopify.com>

* Update translations: merchant (Shopify#1474)

* Update 1 translation file (Shopify#1475)

* Center align payment terms form text when there is no image (Shopify#1473)

* Add grid settings to collections list (Shopify#1469)

* Feat. collection updates (Shopify#1295)

* Update 20 translation files (Shopify#1487)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Theme check manual fixes (Shopify#1379)

* Clean up behaviour when there are only L2 links mega menu (Shopify#1492)

* Center mega menu (Shopify#1482)

* Update 1 translation file (Shopify#1499)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Video alt text info content update (Shopify#935)

* Video alt text info content update

* Update locales/en.default.schema.json

* Update locales/en.default.schema.json

* Update 4 translation files

* Update 3 translation files

* Update 9 translation files

* Update 3 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Adjust color contrast for Vendor on the cart page (Shopify#1462)

* Add support for boolean filters (Shopify#1456)

* Fixed condensed mega menu (Shopify#1504)

* Fixed condensed mega menu

* Fixed bug where product page thumbnail slider arrows were appearing when they shouldnt (Shopify#1510)

* Fixed multicolumn gap spacing on mobile (Shopify#1505)

* Fixed multicolumn gap spacing on mobile

* Fixed max price display on filter drawer (Shopify#1512)

* Theme check TemplateLength (Shopify#1511)

* Add PR checkbox for theme documentation (Shopify#1516)

* Add PR checkbox for theme documentation

* Update .github/PULL_REQUEST_TEMPLATE.md

* Update 1 translation file (Shopify#1517)

* Update 1 translation file (Shopify#1528)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1533)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1536)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Quick Add (Shopify#1388)

* Featured Collection : Fix max width setting (Shopify#1538)

* Fix product rating help doc links (Shopify#1532)

* fix links for product rating

* Update 20 translation files

* update os2 links and remove /en

* update other URL to remove the language path

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Prevent empty heading in contact form (Shopify#1515)

* Only render contact heading if not empty

* Add fallback form heading

* Move title string

* Update 21 translation files

* Update 3 translation files

* Update 6 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Move slideshow control buttons when set to autorotate (Shopify#1523)

* Update 1 translation file (Shopify#1554)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Hide inactive mobile menu items from screen readers (Shopify#1493)

* Hide mobile menu ancestors from screen readers

* Account for close button

* Cleanup on drawer close

* Account for mobile facets drawer

* Vertical filter (Shopify#1443)

* Remove transforms from image with text content (Shopify#1560)

* Fix shop link on giftcard page (Shopify#1557)

Co-authored-by: Max@SMAKK <max-smakk@MacBook-Pro-4.local>

* Using font size and spacing for mega menu hierarchy (Shopify#1520)

* Using font size and spacing for mega menu hierarchy

Co-authored-by: LucasLacerdaUX <lucas.lacerda@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update translations: buyer (Shopify#1581)

* Update 1 translation file

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Quick Add: Fix button overflow on mobile carousel (Shopify#1567)

* Update spacing (Shopify#1588)

* Vertical filter UX follow ups (Shopify#1568)

* Vertical filter follow ups

* Fix button alignment

* Fix search sort

* Fix sort

* Fix wrapping

* Fix overflow

* Fix empty space

* Fix button no js

* Fix button style

* Fix filter column

* Apply secondary style

* Apply button

* Fix search

* Fix no-js layout for drawer and product count position (Shopify#1572)

* fix no-js layout for drawer and product count position

* udpate vertical product count position on drawer on desktop

* fix broken html

* remove unnecessary facets class

* update some logic to fix state after rebase

* fix spacing

* Update margin formatting

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update padding formatting

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add hidden inputs to preserve search queries (Shopify#1585)

* fix no-js layout for drawer and product count position

* udpate vertical product count position on drawer on desktop

* fix broken html

* remove unnecessary facets class

* update some logic to fix state after rebase

* fix spacing

* Add hidden inputs to preserve search queries

Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Version bump v5.0.0 (Shopify#1624)

* Remove unused setting (Shopify#1617)

* Update 5 translation files (Shopify#1626)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1634)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Remove recaptcha visibility hidden on contact form (Shopify#1637)

* Fix Product strucure-data markup for Brand property (Shopify#1600)

* Fix empty collection links (Shopify#1639)

* Fix first image lazy load on main product section (Shopify#1286)

* Make sure first image is not lazy loaded

* Use a single liquid tag

* Update sections/main-product.liquid

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

* replace the hex code by currentColor (Shopify#1591)

* Cart drawer (Shopify#1544)

* Fix button spinner in Safari (Shopify#1646)

* Rich text improvements (Shopify#1635)

* [Header] add setting to tweak top and bottom padding (Shopify#1654)

* Add header padding setting

* Update minimum to 5

* Changed defaults

* Update header with option 2

* Remove unnecessary code

* Update translations: buyer (Shopify#1659)

* Update translations: merchant (Shopify#1681)

* Remove gradient when slide container is set to be hidden on desktop (Shopify#1643)

* Revert flex grow on collage card__content (Shopify#1662)

* Update minimum header padding to zero (Shopify#1688)

* Fix a typo in main-product.liquid (Shopify#1647)

* 1-click Quick Add for products with 1 non-default variant (Shopify#1610)

* Add 1-click quick-add support for products with exactly 1 non-default variant

* Revert "Add 1-click quick-add support for products with exactly 1 non-default variant"

This reverts commit 41648ca.

* Add 1-click quick-add support for products with exactly 1 non-default variant

* Switch to Variants Size

* Update spacing below product media (Shopify#1689)

* Update spacing below product media

* Update visible

* Remove extra spacing

* Update desktop layout

* Revert button type and button 1 ids (Shopify#1705)

* Update Banner image and logo Image to use `image_tag` (Shopify#1701)

* Fix product media slider peek (Shopify#1696)

* Account for gap spacing in product slider width

* Prevent slider arrows with single media

* Remove alt text to improve screen reader experience  (Shopify#1679)

* Update Subtotal header for a11y (Shopify#1680)

* Remove extra whitespace on Quick Add modals (Shopify#1706)

* Always centered

* Non centered

* Revert height

* Set height to initial height

* Revert fixed height

* Remove extra

* Update 1 translation file (Shopify#1715)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Collapsible content] Add vertical padding to blocks (Shopify#1655)

* Fix padding. top and bottom now gets 1.5rem

* Set padding-top to 0

* Fix syntax error caused by missing calc in product CSS (Shopify#1703)

* Update 1 translation file (Shopify#1739)

* Cart drawer section fix (Shopify#1742)

* Update translations: merchant (Shopify#1757)

* Version bump v6.0.0 (Shopify#1769)

* Version bump

Update theme version to v6.0.0

* Update release-notes.md

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update release-notes.md

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update release-notes.md

Co-authored-by: Ludo <ludo.segura@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Fix box shadow being cut off on sliders (Shopify#1772)

* Update contact-form.liquid (Shopify#1716)

* Update main-cart-items.liquid (Shopify#1717)

* Update main-collection-banner.liquid (Shopify#1718)

* Remove menu title requirement (Shopify#1763)

* Menu heading

Remove requirement for menu heading in footer to display

* Update footer.liquid

* Remove helper text

* Remove translations

* Update footer

* Update footer

* Update footer

* Update footer

* Revert changes

* Fixes

* Update

* Update to footer

* Badge padding update (Shopify#1785)

* Add video button aria label  (Shopify#1728)

* Change aria for active pagination nav control (Shopify#1727)

* Update 1 translation file (Shopify#1809)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Warn users that link opens in a new window (Shopify#1735)

* Add unique ids to card-product.liquid headings and product state badges (Shopify#1731)

* Badge product card position copy update (Shopify#1795)

* Badge product card position copy update

* Update 7 translation files

* Update 3 translation files

* Update 6 translation files

* Update 3 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Distinct View All IDs for screen readers (Shopify#1733)

* Fix Quick Add when cart type is set to Page (remove data-cart-type) (Shopify#1817)

* Replaced a missing </div> tag in main-search.liquid (Shopify#1804)

* version bump to 6.0.2 (Shopify#1819)

* Add help text to the Variant Pills settings area (Shopify#1782)

* Add help text to the Variant Pills settings section.

* Update copy as per reviews.

* Update 5 translation files

* Update 4 translation files

* Update 8 translation files

* Update 2 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update translations: buyer (Shopify#1828)

* Update 1 translation file

* Update locales/th.json

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Update translations: merchant (Shopify#1818)

* Update 1 translation file

* Update 1 translation file

* Update 1 translation file

* Update locales/th.schema.json

* Update 1 translation file

* Update th.schema.json

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Remove duplicate .hidden class in base.css (Shopify#1811)

* Setting border-top to 0.1rem to match with header navigation (Shopify#1802)

updating component-facets.css to match div line width from the header

* Add period to Cart global setting info text (Shopify#1751)

* add period to info text

* Update 1 translation file

* Update 9 translation files

* Update 9 translation files

* Update 1 translation file

Co-authored-by: Melissa Perreault <melissaperreault@Melissas-MacBook-Pro.local>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add focus ring/border in Windows High Contrast mode (Shopify#1729)

* Update 1 translation file (Shopify#1836)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Announcment alignment (Shopify#1770)

* Announcement and translation

* Alignment for announcement bar

* Translations

* Update alignment and order of options.

* Update locales/th.schema.json

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

* Uniform padding with link

* Make colour go full width

* Full width hover and justify text

* Update sections/announcement-bar.liquid

Co-authored-by: Ludo <ludo.segura@shopify.com>

* Remove justify

* Remove justify

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>

* Add pagination to main collection list (Shopify#1745)

* Jsonify customer sections (Shopify#1640)

* Update translations: merchant (Shopify#1843)

* Update 20 translation files

* Update 1 translation file

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1849)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update PULL_REQUEST_TEMPLATE.md

* Remove CLA from probot and use new GitHub action (Shopify#1859)

* Update 1 translation file (Shopify#1862)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add `reopened` activity type (Shopify#1874)

* add vendor to popup notification when vendor checkbox is checked (Shopify#1870)

* Add proper product title to data-shopify-title (Shopify#1858)

* Update 1 translation file (Shopify#1872)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Use param_name instead of label to construct an id for filter values (Shopify#839)

* Fix linting issues in feature-product and main-product sections (Shopify#1873)

* fix linting issues in feature-product and main-product sections

* use button--secondary when dynamic checkout or subscriptions enabled (Shopify#1875)

* [Card Settings] Break card global settings into Blog, Collection and Product Cards (Shopify#1774)

* [Header] New logo position (Shopify#1864)

* update predictive search container width (Shopify#1878)

* update predictive search container width on small screens

* Update 20 translation files (Shopify#1891)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix filter bug to allow filters to be removed (Shopify#1890)

* [Product layout] Add desktop media position (Shopify#1720)

* Update 2 translation files (Shopify#1896)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Switch blog header img to eager instead of lazy load (Shopify#1894)

* Update 1 translation file (Shopify#1899)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* fix(sections/header): remove duplicated classnames (Shopify#1853)

* change done in pickup availability (Shopify#1831)

* Fix spaces in menu IDs by replacing titles with handles (Shopify#1846)

* Increase left and top edge for zoom-icon element (Shopify#1902)

* Increase left and top edge for zoom-icon element

* Minor changes that I forgot undo

* Delete unnecessary whitespace

* Change left and top edges to 1.2rem

* fix: drawer - typing in quantity and pressing enter empties cart (Shopify#1881)

* hide quick add button when javascript is disabled (Shopify#1904)

* hide quick add button when javascript disabled

* Update PULL_REQUEST_TEMPLATE.md (Shopify#1892)

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

Adding hidden markdown

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: MM <martina.marien@shopify.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Apply suggestions from code review

* Update .github/PULL_REQUEST_TEMPLATE.md

* Edit based on feedback

Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* Update Lighthouse CI (Shopify#1898)

* Update card style default for collage (Shopify#1922)

* Update 1 translation file (Shopify#1924)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update PULL_REQUEST_TEMPLATE.md to include visual change reference (Shopify#1923)

* Update PULL_REQUEST_TEMPLATE.md

* Change bold to heading markup

* Fix slider padding and whitespace issue on Safari (Shopify#1669)

* Update 1 translation file (Shopify#1928)

* Add a max width to iframes within the product info container (Shopify#1929)

* Fix popup cart notification overlap in the latest Safari version (Shopify#1912)

* Fix video controls on the feat product section (Shopify#1940)

* Update 1 translation file (Shopify#1948)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1949)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#1951)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Product page] Add 2 column layout for desktop and mobile (Shopify#1766)

* Android menu drawer account fix (Shopify#1945)

* Fix android menu drawer not showing account

* remove unnecessary code

* Update 8 translation files (Shopify#1956)

* Use image tag (Shopify#1906)

* image_tag in collage

* image_tag in multicolumn

* image_tag in slideshow

* image_tag in image_with_text

* image_tag in collapsible-content

* image_tag in video

* Apply suggestions from code review

Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>

* PR review: Clean up whitespace on capture def

Co-authored-by: Kyle Conrad <kcomrade53@gmail.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
Co-authored-by: Kyle Conrad <kyle.conrad@shopify.com>

* Complementary products (Shopify#1938)

* Update translations: buyer (Shopify#1963)

* Update 29 translation files

* Update 1 translation file

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix shadow being cut on featured collection slider, featured blog slider and collection list slider (Shopify#1961)

* Fix shadow being cut on feat collection slider

* Missing commit

* Remove file

* Rename

* Add class

* Remove Product Subtitle block from Featured Product section (Shopify#1964)

* Remove Text Block for Product Subtitle on Dawn's pre-configured Product Page and Featured Collection sections

* Remove caption from block order

* Revert change for json templates

* [Complementary product] Keep text alignment to the left for horizontal cards (Shopify#1965)

* Keep text alignment to the left for horizontal cards

* prevent image padding from global product cards settings to apply

* Update version and release notes (Shopify#1966)

* fix margin-top on middle center header option (Shopify#1970)

* Update 1 translation file (Shopify#1967)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* fix slider controls showing in certain scenarios on mobile (Shopify#1973)

* fix closing element (Shopify#1981)

* Variant media modal fix (Shopify#1985)

* Fix duplicate class attr issue

* Prevent use of lazy_load variable in complementary block

* Ensure complementary block loads card css (Shopify#1991)

* [Complementary block] update url from the info text to the latest (Shopify#1974)

* update url from the info text to the latest

* fix parentheses

* Update 20 translation files

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Add version bump and release notes (Shopify#1997)

* Enable language/country selector by default (Shopify#1988)

* Fetch the header (LCP) image at high priority (Shopify#1918)

* [Product page] "Icon with text" block (Shopify#1933)

Add a new Icon-With-Text block to Product Page

* Add shopify attributes to description block on product page (Shopify#2005)

* Add variant picker sold out UI [temporary solution] (Shopify#1407)

* Move product media gallery and modal into snippets [Refactor] (Shopify#1934)

* Move product media gallery and modal into snippets

* Gallery snippet api adjustments

* Fixes for featured product flexibility

* Exclude media_size from gallery api

* Update 1 translation file (Shopify#2023)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Remove setting for variant styling (Shopify#2025)

* Remove setting for variant styling

* wrong edit fix

* Update 30 translation files (Shopify#2026)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Minor improvements to product media liquid [Refactor] (Shopify#2022)

* Refactor ratio usage in product thumbnail

* Fix zoom icon placement and featured product issues

* Minor updates

* Prevent ui changes from variant selection queues (Shopify#2030)

* Prevent hidden Variant Picker block from breaking Quick Add (Shopify#2049)

* Fix 'Cannot read properties of null' error in SliderComponent (Shopify#2053)

* remove redundant role from SVGs (Shopify#2037)

* remove redundant role from SVGs

* hide icons from screen readers

* Fix z-index issue for mega menu in Safari (Shopify#2034)

* Fix z-index issue for mega menu in Safari

* add comment with context

* small edits

* change approach

* [PDP] Add SKU block (Shopify#1987)

Add SKU block to PDP

* Adjust mobile media selectors for new product-thumbnail markup (Shopify#2050)

* Add zoom flexibility (Shopify#1983)

add 'lightbox', 'hover', and 'none' zoom settings to images

* Prevent media background on deferred-media container (Shopify#2068)

* Add Inventory status block (Shopify#1979)

* [Product page & feat. product] Fix unavailable variant issue (Shopify#2031)

Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com>
Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Co-authored-by: Charles-Philippe Clermont <cp.clermont@shopify.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: MM <martina.marien@shopify.com>
Co-authored-by: Talia Harrison-Marcassa <taliahm@users.noreply.github.com>
Co-authored-by: Caroline <mllegeorgesand@gmail.com>
Co-authored-by: Tyler Alsbury <60230011+tyleralsbury@users.noreply.github.com>
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
Co-authored-by: Maximilian Bredow <30573532+bredowmax@users.noreply.github.com>
Co-authored-by: Max@SMAKK <max-smakk@MacBook-Pro-4.local>
Co-authored-by: LucasLacerdaUX <lucas.lacerda@shopify.com>
Co-authored-by: Antonio J <antonio.jhun62@gmail.com>
Co-authored-by: Baldur Helgason <baldur.helgason@gmail.com>
Co-authored-by: Alexander <alex@inso.codes>
Co-authored-by: Lee Siong Chan <leesiongchan@users.noreply.github.com>
Co-authored-by: Peretz Cohen <pizzaz93@users.noreply.github.com>
Co-authored-by: boltgolt <boltgolt@gmail.com>
Co-authored-by: Alistair Lane <alistair.lane@shopify.com>
Co-authored-by: Oliviammarcello <60230008+Oliviammarcello@users.noreply.github.com>
Co-authored-by: James <james@thoughtandmortar.com>
Co-authored-by: Kjell Reigstad <1202812+kjellr@users.noreply.github.com>
Co-authored-by: Gage <ItsGageHolland@gmail.com>
Co-authored-by: Daniel Nieuwenhuizen <danielvan@gmail.com>
Co-authored-by: Melissa Perreault <melissaperreault@Melissas-MacBook-Pro.local>
Co-authored-by: Yevhenii Huselietov <d46k16@gmail.com>
Co-authored-by: Monica Mateiu <monica.mateiu@gmail.com>
Co-authored-by: Monica Mateiu <monica.mateiu@shopify.com>
Co-authored-by: Sia <siakaramalegos@gmail.com>
Co-authored-by: Kasper Andersson <KasperAndersson@users.noreply.github.com>
Co-authored-by: Muhammad Abdullah <76752572+dexter845@users.noreply.github.com>
Co-authored-by: Nathan Dawson <n_dawson@me.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Robert <treboryx@gmail.com>
Co-authored-by: Tyler Rowsell <tyler.rowsell@shopify.com>
Co-authored-by: Kyle Conrad <kcomrade53@gmail.com>
Co-authored-by: Kyle Conrad <kyle.conrad@shopify.com>
Co-authored-by: Lucas Kim <s.lucas.kim@gmail.com>
Co-authored-by: Sia <sia.karamalegos@shopify.com>
Co-authored-by: CFX <cfxd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sections to customer pages
7 participants