Fix for small screens with large fonts don't fit all content #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewetchen
reviewed
Aug 8, 2023
assets/quick-order-list.css
Outdated
| @@ -187,6 +187,12 @@ quick-order-list .quantity__button { | |||
| align-items: center; | |||
| } | |||
|
|
|||
| @media screen and (max-width: 749px) { | |||
| .variant-item__discounted-prices { | |||
| display: block; | |||
There was a problem hiding this comment.
We could use flex-wrap: wrap; instead since display: flex; is already being applied here. Additionally, flex-wrap: wrap would allow the prices to be on the same line when there is available space, whereas display: block forces them to be on separate lines (video).
There was a problem hiding this comment.
Hey Andrew, thanks for a good idea. This makes sense. Fixed.
There was a problem hiding this comment.
Sick! That's a great call, @andrewetchen... sorry, late to catching up with this one. Thank you! 🚀
edmund-teh
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Tested on my phone, iPad, and on Desktop. All looks great and works as advertised. Thanks @eugenekasimov!
TimmersThomas
added a commit
to TimmersThomas/shopify-template-houseofchocolate
that referenced
this pull request
Aug 13, 2023
* upstream/main: (205 commits) Fix for small screens with large fonts don't fit all content (Shopify#2946) Adjust quantity rules margin (Shopify#2948) Update Social media settings defaults to remove Shopify links (Shopify#2830) added json to barcode to pass gtin as a json string (Shopify#2804) Fixed extra margin spacing in collage section when header is empty (Shopify#2770) Track state of mouseenter event (Shopify#2934) Fix misalignment of total items in quick order list (Shopify#2923) Hide vol pricing and qty rules when variant is unavailable (Shopify#2889) Fix font family for quick order list (Shopify#2888) v11.0.0 version bump and release notes (Shopify#2916) Revert "v11.0.0 version bump and release notes (Shopify#2906)" (Shopify#2915) Update quantity-popover.css v11.0.0 version bump and release notes (Shopify#2906) Fix social list styles loading (Shopify#2900) Fix an error (Shopify#2903) Fix hardcoded info color (Shopify#2893) Fix error misalignment for Quick order list (Shopify#2887) Replace generic section name with section ID. (Shopify#2884) Fix cart drawer for variant list and tablet spacing (Shopify#2880) Add missing shadow styles to inputs in Quick Order List (Shopify#2879) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR fixes an issue when the total price of an item on mobile goes out of screen. This happens when an item has
compare_at_priceand large fonts, so in that case there is just not enough room to fit the total price on a small screen.Why are these changes introduced?
Fixes #2931 .
What approach did you take?
I changed the way we display
the old priceand the current one. They used to be in one line. Now I place them in two different lines under each other.Visual impact on existing themes
The layout of
the old priceand the current one has been changed for mobile.Before
After
Testing steps/scenarios
Demo links
Checklist