Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing shadow styles to inputs in Quick Order List #2879

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

sofiamatulis
Copy link
Contributor

@sofiamatulis sofiamatulis commented Jul 20, 2023

PR Summary:

Add missing Global setting shadow styles to inputs in Quick Order List

Editor: https://admin.shopify.com/store/os2-demo/themes/140318343190/editor

Copy link
Contributor

@KaichenWang KaichenWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In extreme cases, the quantity input shadow can start overlapping with nearby text. Maybe not a launch blocker, because the text is still legible enough.

Screenshot 2023-07-20 at 3 44 05 PM

Screenshot 2023-07-20 at 3 25 59 PM

@sofiamatulis
Copy link
Contributor Author

In extreme cases, the quantity input shadow can start overlapping with nearby text. Maybe not a launch blocker, because the text is still legible enough.

Screenshot 2023-07-20 at 3 44 05 PM

Screenshot 2023-07-20 at 3 25 59 PM

It looks like it also happens with the price per item: https://screenshot.click/20-09-qv7jv-l4416.png

cc @edmund-teh @nicklepine We can track this in fast follows

Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sofiamatulis sofiamatulis merged commit 5e8ac23 into release/11.0.0-rc Jul 20, 2023
@sofiamatulis sofiamatulis deleted the variantlist-globalstyles branch July 20, 2023 15:52
sjflaher added a commit that referenced this pull request Jul 27, 2023
* Price per item, Popover and global style bugs (#2851)

* Fix cart submission on Quick Order List (#2868)

* replace translation string to have the translation visible (#2869)

* B2B compare at price with price range (#2858)

* Add sale badge and price-range for volume-pricing

* Add compare_at price to PDP and Feat Prod.

* Change opacity to 100% for price per item.

* Update the logic

* Hide price per item for unavailable variants.

* Remove margin for dl.

* Refactoring

* Correct a mistake in liquid.

* Change the JS logic back for updating price per item

* Add compare at to prod card. Add style to compare at

* Add missing shadow styles to inputs in Quick Order List (#2879)

* Fix cart drawer for variant list and tablet spacing (#2880)

* Replace generic section name with section ID. (#2884)

* Fix error misalignment for Quick order list (#2887)

* Fix error misalignment

* Reduce top space. Address feedback.

* Fix hardcoded info color (#2893)

* Fix an error (#2903)

* Fix social list styles loading (#2900)

* v11.0.0 version bump and release notes (#2906)

* Update quantity-popover.css

Add new line at end of file

* Revert "v11.0.0 version bump and release notes (#2906)" (#2915)

This reverts commit 13dec2a.

* v11.0.0 version bump and release notes (#2916)

---------

Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
TimmersThomas added a commit to TimmersThomas/shopify-template-houseofchocolate that referenced this pull request Aug 13, 2023
* upstream/main: (205 commits)
  Fix for small screens with large fonts don't fit all content (Shopify#2946)
  Adjust quantity rules margin (Shopify#2948)
  Update Social media settings defaults to remove Shopify links (Shopify#2830)
  added json to barcode to pass gtin as a json string (Shopify#2804)
  Fixed extra margin spacing in collage section when header is empty (Shopify#2770)
  Track state of mouseenter event (Shopify#2934)
  Fix misalignment of total items in quick order list (Shopify#2923)
  Hide vol pricing and qty rules when variant is unavailable (Shopify#2889)
  Fix font family for quick order list (Shopify#2888)
  v11.0.0 version bump and release notes (Shopify#2916)
  Revert "v11.0.0 version bump and release notes (Shopify#2906)" (Shopify#2915)
  Update quantity-popover.css
  v11.0.0 version bump and release notes (Shopify#2906)
  Fix social list styles loading (Shopify#2900)
  Fix an error (Shopify#2903)
  Fix hardcoded info color (Shopify#2893)
  Fix error misalignment for Quick order list (Shopify#2887)
  Replace generic section name with section ID. (Shopify#2884)
  Fix cart drawer for variant list and tablet spacing (Shopify#2880)
  Add missing shadow styles to inputs in Quick Order List (Shopify#2879)
  ...
SmolSoftBoi pushed a commit to m-k-enterprises/dawn that referenced this pull request Feb 18, 2024
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants