Make executor_class optional in trace class

[swalkinshaw]

Otherwise Schema.new_trace will require executor_class as a keyword arg which is the wrong place to pass it in.

@rmosolgo should execute_multiplex check for the existence of executor_class or is this existing one enough?

graphql-batch/lib/graphql/batch/executor.rb

Lines 22 to 24 in 8e88b28

	unless executor
	raise NoExecutorError, 'Cannot end a batch without an Executor.'
	end

[rmosolgo]

I think this was in the right place. I ran into a bug here too, but I think it was a bug in GraphQL-Ruby (It was with backtrace: true), which I addressed in rmosolgo/graphql-ruby#4849

Did you encounter an error here too?

[swalkinshaw]

We actually aren't using the backtrace feature right now. I also patched our schema class with that fix and the exception still happens.

But you're right that this isn't the proper place to fix it. I think it's an issue with custom trace modes:

(ruby) Schema.trace_options_for(:default)
{:executor_class=>GraphQL::Batch::Executor, :schema_handle=>"admin"}
(ruby) Schema.trace_options_for(:metrics)
{:schema_handle=>"admin"}

In this case we're using Schema.new_trace(mode: :metrics).

[rmosolgo]

Oh, OK -- different bug 😅 I think this will fix it: rmosolgo/graphql-ruby#4850

(It should just work -- the option given to the default mode should have been available to downstream, derived modes, too. The trace module was mixed in, but the options hash wasn't properly merged.)

[swalkinshaw]

looks good, thank you 🎉

[rmosolgo]

Cool -- I just released in GraphQL-Ruby v.2.2.10! Let me know if you run into any more trouble with it.