Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct variable names for Oxygen #354

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

jplhomer
Copy link
Contributor

@jplhomer jplhomer commented Jan 5, 2023

Fixes #353

Copy link
Member

@max611 max611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏 I looked at Core and SHOPIFY_ variables are marked as deprecated.

@jplhomer jplhomer merged commit b4a0fd7 into v0.x-2022-10 Jan 5, 2023
@jplhomer jplhomer deleted the jl-use-correct-env-vars branch January 5, 2023 16:17
SHOPIFY_STOREFRONT_API_PUBLIC_TOKEN: string;
SHOPIFY_STOREFRONT_API_VERSION: string;
SHOPIFY_STORE_DOMAIN: string;
PUBLIC_STOREFRONT_API_TOKEN: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this affects the public docs, can you please create a ticket so that our team can triage

cc. @jojordan4 you might already be aware of this, but I'm not sure if the expectation is to read changes from PRs.

@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new Oxygen variable formats for tokens etc
4 participants