Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred response never resolves when there is a hydration error #1182

Closed
danielmoraes opened this issue Aug 3, 2023 · 2 comments
Closed
Labels

Comments

@danielmoraes
Copy link

danielmoraes commented Aug 3, 2023

What is the location of your example repository?

https://github.com/Form-Factory/sample-hydrogen

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2023.4.5

What version of Remix are you using?

1.17.1

Steps to Reproduce

You can reproduce the issue with the repo above, by reloading the home page a few times.

In general, you can reproduce it by:

  • Force a hydration error (see options here)
  • Defer a promise in the loader
  • See that the deferred data sometimes loads, some other times doesn't

This issue is also being discussed here.

Expected Behavior

The featured products and collections to load.

drawing

Actual Behavior

The featured products and collections promises never resolves, thus doesn't load.

drawing
@danielmoraes danielmoraes changed the title defer defer never resolves when there is a hydration error Aug 3, 2023
@danielmoraes danielmoraes changed the title defer never resolves when there is a hydration error Deferred response never resolves when there is a hydration error Aug 3, 2023
@danielmoraes danielmoraes reopened this Aug 11, 2023
@frandiox
Copy link
Contributor

Hi! It seems it was fixed in Remix remix-run/remix#5165 but not released yet.

@blittle blittle closed this as completed Jun 21, 2024
@blittle
Copy link
Contributor

blittle commented Jun 21, 2024

Should be resolved with newer remix versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants