Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuyNowButton @shopify/hydrogen-react should allow sellingPlanId #1515

Closed
edoardolunardi opened this issue Nov 17, 2023 · 0 comments · Fixed by #2254
Closed

BuyNowButton @shopify/hydrogen-react should allow sellingPlanId #1515

edoardolunardi opened this issue Nov 17, 2023 · 0 comments · Fixed by #2254

Comments

@edoardolunardi
Copy link

What is the location of your example repository?

None

Which package or tool is having this issue?

hydrogen-react

What version of that package or tool are you using?

2023.10.0

What version of Remix are you using?

None

Steps to Reproduce

BuyNowButton doesn't allow sellingPlanId prop.

Expected Behavior

I would expect the BuyNowButton to receive a sellingPlanId prop, along with the usual variantId. This would allow to add a subscription to the cart + redirect to checkout without extra custom logic.

Actual Behavior

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants