Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(demo-store): Refactor Seo and implement ld+json structured data [Fixed] #660

Merged
merged 8 commits into from
Mar 7, 2023
Merged

(demo-store): Refactor Seo and implement ld+json structured data [Fixed] #660

merged 8 commits into from
Mar 7, 2023

Conversation

juanpprieto
Copy link
Contributor

@juanpprieto juanpprieto commented Mar 7, 2023 •
edited
Loading

Replaces the prev approved PR #651

WHY are these changes introduced?

Improve the demo store Seo implementation by ensuring all routes include seo meta and structured ld+json data.

Closes first task of https://github.com/orgs/Shopify/projects/5093?pane=issue&itemId=22169300

WHAT is this pull request doing?

  • Adds a new lib utility seoPayload to help manage seo and ld+json payloads in a centralized location ~/libs/seo.server.ts
  • Consolidates seo config strategy to use loader(s).seo return instead of handle.seo
  • Adds a reference structured data implementation to all applicable routes.

seoPayload helper

// ~/libs/seo.server.ts
export const seoPayload = {
  article,
  blog,
  collection,
  home,
  listCollections,
  page,
  policies,
  policy,
  product,
  root,
};

Example implementation product route

// ~/routes/products/$productHandle.tsx
import {seoPayload} from '~/libs/seo.server';

export async function loader({request}) {
  // ... 
  const seo = seoPayload.product({
    product,
    selectedVariant,
    url: request.url,
  });
  return {product, seo}
}

similar helper for all other routes...

// ~/routes/collections/$collectionHandle.tsx
import {seoPayload} from '~/libs/seo.server';

export async function loader({request}) {
  // ... 
  const seo = seoPayload.collection({collection, url: request.url})
  return {collection, seo}
}

Replaces #651

HOW to test your changes?

  • Navigate all routes and inspect the <head> tag for title and seo meta tags as well as ld+json <script/> tags.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

juanpprieto and others added 7 commits March 6, 2023 21:00
@juanpprieto
refactor seo and implement ld+json structured data
157e641
@juanpprieto
Update templates/demo-store/app/lib/seo.server.ts
ebd3ffa 
Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com>
@juanpprieto
Update templates/demo-store/app/routes/($lang)/search.tsx
d21a443 
Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com>
@cartogram @juanpprieto
Fix bug in create CLI using --install-deps flag (#644)
4d042d6 
* Fix bug in create CLI using `--install-deps` flag

* Use flags to camel case util

* Add tests for init

---------

Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com>
@rafaelstz @juanpprieto
Hero images loading eager (#641)
6bde521
@cartogram @juanpprieto
Remove Turbo cache in Oxygen deplyment (#655)
cbce6c6 
Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com>
@cartogram @juanpprieto
Remove Turbo cache from typescript build action (#656)
ebc4c6e 
Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com>
@juanpprieto juanpprieto mentioned this pull request Mar 7, 2023
Closed
5 tasks
@juanpprieto
fix search products count
3a53aea 
fix search products count
@juanpprieto juanpprieto force-pushed the @juanpprieto/seo-jsonld-backup branch from 9aca06f to 3a53aea Compare March 7, 2023 23:35
@juanpprieto juanpprieto merged commit f77b1fa into 2023-01 Mar 7, 2023
@juanpprieto juanpprieto deleted the @juanpprieto/seo-jsonld-backup branch March 7, 2023 23:49
@juanpprieto juanpprieto mentioned this pull request Mar 10, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpprieto @rafaelstz