Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hydrogen Skeleton] Issues with Predictive Search + Search page improvements #1760

Closed
BrendaSegalShopify opened this issue Feb 14, 2024 · 1 comment · Fixed by #1783
Closed

Comments

@BrendaSegalShopify
Copy link

What is the location of your example repository?

Hydrogen Skeleton

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

xxxxx

What version of Remix are you using?

No response

Steps to Reproduce

cc @juanpprieto this is the issue covering what we discussed in our Hydrogen Developer Tools research meeting.

Predictive Search

  1. When typing in a letter, the Predictive Search results show, but then are immediately reloaded with the empty state
  2. The search button doesn't work
image

Storefront Search

For the Storefront Search results, we should add:

  1. trackingParameters (these are included in Predictive Search results already, I believe)
  2. Images
  3. Pricing (for products)

Expected Behavior

Already described in the steps to reproduce

Actual Behavior

Already described in the steps to reproduce

@BrendaSegalShopify BrendaSegalShopify changed the title Issues with Predictive Search + Search page improvements [Hydrogen Skeleton] Issues with Predictive Search + Search page improvements Feb 14, 2024
@vitaliy-bobrov
Copy link

I believe the problem with predictive search was caused by enabling 'v3_fetcherPersist' flag in config, with this one set to false it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants