Update dependencies used in development and on CI #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
reviewed
Jan 20, 2021
| gem.add_development_dependency('spy') | ||
| gem.add_development_dependency('minitest', '>= 2.11.0') | ||
|
|
||
| if RUBY_PLATFORM == 'java' |
There was a problem hiding this comment.
I believe this changes behaviour when someone tries to run this gem on JRuby, right?
There was a problem hiding this comment.
It was just raising before. However, there is no need to add that constraint here, since Identity Cache doesn't itself require MRI ruby, even though we end up testing with MRI specific backends.
| gem 'byebug', platform: :mri | ||
| gem 'stackprof', platform: :mri |
There was a problem hiding this comment.
Why are we specifying MRI only (platform: :mri) for these gems? I assume it is related to native extensions.
There was a problem hiding this comment.
Yeah, these are native extensions, so we can just not install them when not using MRI.
rafaelfranca
approved these changes
Jan 20, 2021
| @@ -3,5 +3,8 @@ gemspec path: '..' | |||
|
|
|||
| gem 'activerecord', github: 'rails/rails' | |||
| gem 'activesupport', github: 'rails/rails' | |||
There was a problem hiding this comment.
Suggested change
| gem 'activesupport', github: 'rails/rails' | |
| gem 'activesupport', github: 'rails/rails', branch: 'main' |
Co-authored-by: Rafael França <rafael.franca@shopify.com>
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that we were using some old development dependencies (e.g. mocha 0.14.0 is from 2013), weren't actually testing the latest version of optional runtime dependencies (e.g. memcached_store) and weren't testing the latest version of ruby (3) on CI.
Solution
I used the gemspec to specify the common development and CI dependencies and pinned these dependencies to a major version.
I've added a version constraint for optional runtime dependencies in gemfiles/Gemfile.min-supported and removed these constraints from gemfiles/Gemfile.latest-release so that we can test old and new versions of these gems.
The above allowed ruby 3 to be tested without issues, so I updated CI to use ruby 3 as the latest ruby version.