Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePullBackOff and RunContainerError should fail deploys #54

Closed
KnVerey opened this issue Feb 27, 2017 · 1 comment
Closed

ImagePullBackOff and RunContainerError should fail deploys #54

KnVerey opened this issue Feb 27, 2017 · 1 comment
Labels
✨ enhancement Improvement or small feature

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Feb 27, 2017

There is currently rudimentary detection for ImagePullBackOff and RunContainerError, but it results in warnings most people ignore. These states should fail the deploy either immediately or after they have been seen a couple times in a row (livenessProbe-style).

Related #34.
@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Feb 27, 2017
@KnVerey KnVerey mentioned this issue Feb 27, 2017
Closed
@KnVerey KnVerey mentioned this issue Mar 19, 2017
Closed
@KnVerey
Copy link
Contributor Author

KnVerey commented Jul 12, 2017

Fixed by #116. Both of those conditions now fail the deploy when observed on all pods in the new ReplicaSet.

@KnVerey KnVerey closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement Improvement or small feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnVerey