Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powered_by_link not providing an accessible warning #1581

Open
ludoboludo opened this issue Jun 9, 2022 · 1 comment
Open

powered_by_link not providing an accessible warning #1581

ludoboludo opened this issue Jun 9, 2022 · 1 comment

Comments

@ludoboludo
Copy link

The powered_by_link object doesn't output a link that is deemed accessible enough.

The link is being opened in a new window/tab so having a warning for screen readers can be useful. We tend to add this behaviour on our Shopify flagship themes.

Here is the github issue from our public repo outlining the issue: Shopify/dawn#720

We could create work around via JS but ideally we don't need to add extra logic like this to make the outcome of the object accessible.

@ludoboludo
Copy link
Author

Also mentioned in this PR: Shopify/dawn#1735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant