Remove extraneous requires #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to stop requiring pieces of Packwerk upfront to prevent cases like #333. This also adds autoload entries for DefaultOffensesFormatter and DependencyValidator if the defaults aren't already loaded (and removes an entry for PrivacyChecker, since it has been extracted).
We move nested autoloads for some files because they trigger autoloads early, which we don't want.
gmcgibbon
commented
Mar 15, 2023
gmcgibbon
force-pushed
the
remove_extraneous_requires
branch
2 times, most recently
from
daa8353
to
16c91cc
Compare
gmcgibbon
force-pushed
the
remove_extraneous_requires
branch
from
16c91cc
to
ca8cf4f
Compare
andrewn617
approved these changes
Mar 21, 2023
shioyama
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Closes #335
Remove extraneous requires from the main require file, and clean up early autoloads.
What approach did you choose and why?
Lazily load checkers, validators, and offense formatters so that we don't need to add requires for them in the main file. I also moved the nested autoloads into nested files to make sure they don't load early.
What should reviewers focus on?
This should make sure load times for Packwerk are minimal if the user chooses to add the gem without
require: false.Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist