-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal.Section]: Fix in Modal.Section divider color #4021
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
🟡 This pull request modifies 2 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected. Details:All files potentially affected (total: 5)
📄
|
Morning! Just in case, first time contributing with Polaris and I am not sure if I had to add the entry to UNRELEASED.md file or is it something that happen after it is merged (or after approved). |
This looks awesome to me 🎉 Can you add an entry to UNRELEASED.md? I also want to get @alex-page 👀 on this to make double sure we're using divider in the correct way here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just need the changelog entry in UNRELEASED.md
Thanks! I will merge as soon the CI is done! |
a03b5fb
to
99f5659
Compare
🎉 Thanks for your contribution to Polaris React! |
WHY are these changes introduced?
I was creating a Modal component with different sections and I noticed that the color of the divider line between the section was darker than the line that divides the footer and header of the modal. I went to Polaris channel and I was told that the color was not the correct one, so I change to use the border('divider').
WHAT is this pull request doing?
This is before:
This is After:
🎩 checklist
README.md
with documentation changes