Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal.Section]: Fix in Modal.Section divider color #4021

Merged
1 commit merged into from
Feb 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2021

WHY are these changes introduced?

I was creating a Modal component with different sections and I noticed that the color of the divider line between the section was darker than the line that divides the footer and header of the modal. I went to Polaris channel and I was told that the color was not the correct one, so I change to use the border('divider').

WHAT is this pull request doing?

This is before:

Screen Shot 2021-02-25 at 9 34 24 AM

This is After:

Screen Shot 2021-02-25 at 9 33 45 AM

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@ghost
Copy link

ghost commented Feb 25, 2021

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost requested review from mirualves and kyledurand February 25, 2021 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021

🟡 This pull request modifies 2 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 5)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Modal/components/Section/Section.scss (total: 5)

Files potentially affected (total: 5)

@ghost
Copy link
Author

ghost commented Feb 25, 2021

Morning! Just in case, first time contributing with Polaris and I am not sure if I had to add the entry to UNRELEASED.md file or is it something that happen after it is merged (or after approved).

@kyledurand
Copy link
Member

This looks awesome to me 🎉 Can you add an entry to UNRELEASED.md? I also want to get @alex-page 👀 on this to make double sure we're using divider in the correct way here.

Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just need the changelog entry in UNRELEASED.md

@ghost
Copy link
Author

ghost commented Feb 25, 2021

Thanks! I will merge as soon the CI is done!

UNRELEASED.md Show resolved Hide resolved
@ghost ghost force-pushed the polaris_divider_modal_section_color branch from a03b5fb to 99f5659 Compare February 26, 2021 15:06
@ghost ghost merged commit 0d508df into main Feb 26, 2021
@ghost ghost deleted the polaris_divider_modal_section_color branch February 26, 2021 15:17
@ghost
Copy link

ghost commented Feb 26, 2021

🎉 Thanks for your contribution to Polaris React!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants