-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EmptyState] Remove legacy styles from empty state within page context #4140
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
🟢 This pull request modifies 3 files and might impact 1 other files. Details:All files potentially affected (total: 1)📄
|
1acc08a
to
d110c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think these changes are good, but one important thing to note is that all empty states should be nested within cards if they're going onto a page. This is the new pattern after the new design language shipped.
I think the changes are worth making but I wouldn't include the story example because that's not a pattern we want to see start to emerge / deviate.
778d291
to
d3855e5
Compare
Example removed! The usage within page context is coming from outside of admin, hence the difference in design patterns :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Thanks @szuchnik !
/shipit |
size-limit report
|
/shipit |
🎉 Thanks for your contribution to Polaris React! |
WHY are these changes introduced?
Empty state was not centering its components within page context, due to styles from before
new design language
still being applied. The repositioning of the image seems to be an echo of the time when EmptyState was laid out in two columns.The image above is the previous state, below you can see how this component will look after the update.
Fixes #0000
WHAT is this pull request doing?
Remove condition applying styles from old design language and associated style rules. Add documentation for page context usecase.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes