Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon - Delete backdrop, change color to tone, fix warning => critical mapping #10208

Closed
4 tasks done
Tracked by #9914
kyledurand opened this issue Aug 24, 2023 · 0 comments
Closed
4 tasks done
Tracked by #9914

Icon - Delete backdrop, change color to tone, fix warning => critical mapping #10208

kyledurand opened this issue Aug 24, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

kyledurand commented Aug 24, 2023 •
edited

@kyledurand kyledurand mentioned this issue Aug 24, 2023
Closed
@kyledurand kyledurand added #gsd:36573 Polaris API Alignment and removed untriaged labels Aug 24, 2023
@kyledurand kyledurand self-assigned this Aug 24, 2023
@kyledurand kyledurand mentioned this issue Aug 24, 2023
Merged
kyledurand added a commit that referenced this issue Aug 24, 2023
@kyledurand @sarahill
[Icon] Update props (#10220)
2b0cdb2 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10208

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

* Removes `backdrop`
* Replaces `color` with `tone`
* Matches warning tone to warning icon color

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

---------

Co-authored-by: Sara Hill <sara.hill@shopify.com>
@kyledurand kyledurand reopened this Aug 28, 2023
@kyledurand kyledurand mentioned this issue Aug 28, 2023
Merged
kyledurand added a commit that referenced this issue Aug 29, 2023
@kyledurand
Update icon migration docs (#10258)
1a10b94 
Closes #10208
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sarahill @sophschneider
[Icon] Update props (#10220)
eb7e258 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10208

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

* Removes `backdrop`
* Replaces `color` with `tone`
* Matches warning tone to warning icon color

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

---------

Co-authored-by: Sara Hill <sara.hill@shopify.com>
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
Update icon migration docs (#10258)
c7a0a00 
Closes #10208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyledurand