Update icon migration docs #10258
Merged
Update icon migration docs #10258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
update-icon-migration-guide
branch
from
3038f4d
to
78bb012
Compare
kyledurand
commented
Aug 29, 2023
| @@ -12,23 +12,23 @@ Polaris v12.0.0 ([full release notes](https://github.com/Shopify/polaris/release | |||
|
|
|||
| - One third: | |||
|
|
|||
| `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="Layout.Section" --from="oneThird" --to="variant" --newValue="oneThird"` | |||
| `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="Layout.Section" --from="oneThird" --to="variant" --toValue="oneThird"` | |||
There was a problem hiding this comment.
Matches the new api. from to, fromValue toValue
https://github.com/Shopify/polaris/blob/main/polaris-migrator/src/utilities/jsx.ts#L131C4-L131C4
aveline
approved these changes
Aug 29, 2023
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10208