Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow value changes in prop migration #10246

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

kyledurand
Copy link
Contributor

WHY are these changes introduced?

Fixes #10233

WHAT is this pull request doing?

Necessary for Icon changes where we're changing color to tone, and also mapping highlight to info, warning to caution.

Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kyledurand kyledurand merged commit 1947b46 into main Aug 28, 2023
10 checks passed
@kyledurand kyledurand deleted the allow-prop-values-changes branch August 28, 2023 17:57
kyledurand pushed a commit that referenced this pull request Aug 31, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.21.0

### Minor Changes

- [#10246](#10246)
[`1947b4691`](1947b46)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added the ability
to migrate prop values

### Patch Changes

- [#10215](#10215)
[`e4a6d47ab`](e4a6d47)
Thanks [@aveline](https://github.com/aveline)! - Fixed a bug in the
rename prop migration

## @shopify/polaris@11.14.0

### Minor Changes

- [#9907](#9907)
[`ef7ddb4ac`](ef7ddb4)
Thanks [@MaxCloutier](https://github.com/MaxCloutier)! - Add a search
field to filter ActionList that have more than 10 items

### Patch Changes

- [#10288](#10288)
[`cd1578230`](cd15782)
Thanks [@ssetem](https://github.com/ssetem)! - Only apply apple dynamic
text to mobile breakpoint


- [#10292](#10292)
[`72f55e32f`](72f55e3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added check for
string type before calling string method


- [#10211](#10211)
[`ac044b3c9`](ac044b3)
Thanks [@peterlazzarino](https://github.com/peterlazzarino)! - Ensure
Avatar has no background color if an source prop is passed in to allow
for transparent images


- [#10287](#10287)
[`9b14e231a`](9b14e23)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed focus ring and
input text styles on `ActionList.SearchField` component

## polaris.shopify.com@0.57.2

### Patch Changes

- Updated dependencies
\[[`ef7ddb4ac`](ef7ddb4),
[`cd1578230`](cd15782),
[`72f55e32f`](72f55e3),
[`ac044b3c9`](ac044b3),
[`9b14e231a`](9b14e23)]:
    -   @shopify/polaris@11.14.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Fixes Shopify#10233

### WHAT is this pull request doing?

Necessary for Icon changes where we're changing `color` to `tone`, and
also mapping `highlight` to `info`, `warning` to `caution`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migration for prop key, value change
3 participants