Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled option for other form elements #114

Closed
LeoAref opened this issue Jun 30, 2017 · 3 comments
Closed

Disabled option for other form elements #114

LeoAref opened this issue Jun 30, 2017 · 3 comments

Comments

@LeoAref
Copy link

LeoAref commented Jun 30, 2017

Now we have disabled option for TextField and Select elements, but other elements like Checkbox and ChoiceList doesn't have it

I have many use cases that I need to disable/enable programmatically a choice in ChoiceList, the same goes for Checkbox, RadioButton, ...

@LeoAref
Copy link
Author

LeoAref commented Jun 30, 2017

I can help with PR implementing that

@lemonmade
Copy link
Member

Thanks for the issue, @LeoAref. Checkbox and RadioButton actually do support disabled, we just have not documented them:

https://github.com/Shopify/polaris/blob/master/src/components/Checkbox/Checkbox.tsx#L20
https://github.com/Shopify/polaris/blob/master/src/components/RadioButton/RadioButton.tsx#L14

ChoiceList does not currently support disabled choices, but this will be part of the next version.

I've added an issue to our internal tracker to update the missing documentation, and will close this issue once we release a version with the fix.

@LeoAref
Copy link
Author

LeoAref commented Jun 30, 2017

@lemonmade Thanks, waiting for the new release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants