Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stretch] Coordinate with App Bridge team for leave confirmation shake #12267

Closed
Tracked by #12269
sophschneider opened this issue Jun 14, 2024 · 6 comments
Closed
Tracked by #12269
Assignees
Labels
#gsd:38420 Top bar and global reframe project Priority: Medium Non-blocking regression, noticable inconcistency, or important feature

Comments

@sophschneider
Copy link
Contributor

sophschneider commented Jun 14, 2024

App bridge next has shake but not app bridge host bc they have their own leave confirmation component

https://github.com/Shopify/app-bridge/blob/main/packages/app-bridge-host/src/components/ContextualSaveBar/LeaveConfirmation/LeaveConfirmation.tsx

This needs to be updated to use the new shake. Their team said they would do it but it will be after summer editions

More context https://github.com/Shopify/polaris-internal/issues/356

Additionally there is an upgrade path for apps > move to app bridge next

@sophschneider sophschneider added #gsd:38420 Top bar and global reframe project Priority: Low Small, subtle details labels Jun 14, 2024
@sophschneider
Copy link
Contributor Author

I have this PR up https://github.com/Shopify/app-bridge/pull/3241 that successfully implements the shake!

Only issue is I can't currently find a way to access beta flags in app bridge. For now, we will have to wait until 100% rollout is stable, and then ship this

@sophschneider sophschneider added the Blocked Something is preventing progress on this issue label Jun 19, 2024
@sophschneider
Copy link
Contributor Author

Setting this as blocked until we have rolled out polaris_dynamic_top_bar_and_reframe to 100% and is stable

@sophschneider
Copy link
Contributor Author

@sophschneider sophschneider removed the Priority: Low Small, subtle details label Jul 2, 2024
@laurkim laurkim added Priority: Medium Non-blocking regression, noticable inconcistency, or important feature and removed Blocked Something is preventing progress on this issue labels Jul 11, 2024
@laurkim laurkim added the Blocked Something is preventing progress on this issue label Jul 25, 2024
@sophschneider sophschneider removed the Blocked Something is preventing progress on this issue label Jul 29, 2024
@sophschneider sophschneider self-assigned this Aug 2, 2024
@sophschneider sophschneider added the Blocked Something is preventing progress on this issue label Aug 2, 2024
@sophschneider
Copy link
Contributor Author

sophschneider commented Aug 2, 2024

Moving this back to blocked as snapit is broken in app bridge, asked for some help in fixing it

@sophschneider sophschneider changed the title Coordinate with App Bridge team for leave confirmation shake [Stretch] Coordinate with App Bridge team for leave confirmation shake Aug 13, 2024
@sophschneider sophschneider removed the Blocked Something is preventing progress on this issue label Aug 15, 2024
@sophschneider
Copy link
Contributor Author

I put this PR up https://github.com/Shopify/app-bridge/pull/3241

the app bridge team needs to review and merge, since I don't have merging permissions in that repo. Made a post in their app ui channel

@sophschneider
Copy link
Contributor Author

In this PR https://github.com/Shopify/app-bridge/pull/3241#issuecomment-2296467416

Team was concerned about the breaking changes this would require. We have passed of the PR that adapts the shake into AB3, team can do whatever option they think is best moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:38420 Top bar and global reframe project Priority: Medium Non-blocking regression, noticable inconcistency, or important feature
Projects
None yet
Development

No branches or pull requests

2 participants