Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete][4.12.0] - Loading prop does not load combo box #2848

Closed
j-rooks opened this issue Mar 16, 2020 · 2 comments
Closed

[Autocomplete][4.12.0] - Loading prop does not load combo box #2848

j-rooks opened this issue Mar 16, 2020 · 2 comments

Comments

@j-rooks
Copy link

j-rooks commented Mar 16, 2020

Issue summary

Using the Autocomplete component, the loading combo box does not show up despite passing the correct value to the loading prop, see:

out

Expected behavior

The loading combo box should appear before displaying the list of loaded options.

Actual behavior

The combo box only appears once the options have loaded.

Steps to reproduce the problem

Observed this issue when working on this PR

  1. Checkout the above PR and navigate to /admin/payments/account
  2. Enter あ in the "Bank Name" input
  3. The loading combo box doesn't appear but the list of options appears correctly

Note: The above gif includes the following code before return:

if (loading) console.log('LOADING', loading, value, data);
else console.log('NOT LOADING', loading, value, data);

Reduced test case

https://codesandbox.io/s/adoring-wescoff-ymzrc

  1. Clear the input and enter a then z -> The options are loaded, then the spinner shows up
  2. Clear the input and enter z -> loading is now true but the spinner does not show up

Specifications

  • Are you using the React components? (Y/N):
  • Polaris version number: 4.12.0
  • Browser: Chrome
  • Device: MacBook Pro
  • Operating System: MacOS Catalina 10.15.2
@ghost
Copy link

ghost commented Mar 16, 2020

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost
Copy link

ghost commented Mar 16, 2021

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.

@ghost ghost added the Icebox label Mar 16, 2021
@ghost ghost closed this as completed Mar 24, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant