Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextContainer - Delete deprecated component #9996

Closed
Tracked by #9914
yurm04 opened this issue Aug 10, 2023 · 4 comments
Closed
Tracked by #9914

TextContainer - Delete deprecated component #9996

yurm04 opened this issue Aug 10, 2023 · 4 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@yurm04
Copy link
Contributor

yurm04 commented Aug 10, 2023

No description provided.

@yurm04 yurm04 mentioned this issue Aug 10, 2023
Closed
@yurm04
Copy link
Contributor Author

yurm04 commented Aug 10, 2023 •
edited
Loading

TextContainer was slated to be deprecated a few months back. Can we delete it instead? There's a migration PR open that I shipped and then got reverted due to issues with regressions. We could take another stab at the migration

web migration https://github.com/Shopify/web/pull/84360
polaris migration script #8424

@yurm04 yurm04 changed the title TextContainer - spacing to gap TextContainer - Delete deprecated component Aug 10, 2023
@yurm04
Copy link
Contributor Author

yurm04 commented Aug 10, 2023

opted to delete this component rather than migrate the props

@yurm04
Copy link
Contributor Author

yurm04 commented Aug 14, 2023

Dependency on VerticalStack #9984 let's wait until it's renamed to BlockStack before deleting/migrating in our own codebase ex.

polaris/polaris-react/src/components/Banner/Banner.stories.tsx

Lines 141 to 152 in 1d82a3b

<TextContainer>
<Banner action={{content: 'Connect account'}} status="warning">
<p>
Connect your instagram account to your shop before proceeding.
</p>
</Banner>
<p>
Use Instagram posts to share your products with millions of
people. Let shoppers buy from your store without leaving
Instagram.
</p>
</TextContainer>

@sam-b-rose sam-b-rose added #gsd:36573 Polaris API Alignment and removed API Alignment labels Aug 15, 2023
@kyledurand kyledurand self-assigned this Sep 14, 2023
@kyledurand kyledurand mentioned this issue Sep 14, 2023
Closed
@kyledurand
Copy link
Member

Closing due to complications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurm04 @kyledurand @sam-b-rose