#1665: Fixed issue with RN Skia not building on RN 0.72 #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that we were using some now-deprecated setings for artifact publishing. We've now done as Expo does here (expo/expo#22537) to remedy the error. I've tested it with a fresh 0.72 install and also with our 0.72 example version.
wcandillon
approved these changes
Jun 24, 2023
|
it's our pleasure to have your support for expo sdk. thanks @chrfalch! will update to new react-native-skia version once it's published. |
|
@Kudo it's published at |
|
thanks @wcandillon! having the pr on the go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that we were using some now-deprecated setings for artifact publishing.
We've now done as Expo does here (expo/expo#22537) to remedy the error.
I've tested it with a fresh 0.72 install and also with our 0.72 example version.
The updated code was added by @mrousavy to accomplish some magic tricks in vision camera.
Thanks to @Kudo who once again keeps his eyes open for so many small things. <3
fixes #1665