Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1665: Fixed issue with RN Skia not building on RN 0.72 #1668

Merged
merged 2 commits into from
Jun 24, 2023
Merged

#1665: Fixed issue with RN Skia not building on RN 0.72 #1668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c088f41
Fixed issue with RN Skia not building on RN 0.72
chrfalch Jun 24, 2023
ac44ca6
Merge branch 'main' into fix/1665-fix-android-gradle-8-rn-072
chrfalch Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 6 additions & 10 deletions package/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ android {
abortOnError false
}

publishing {
singleVariant("release") {
withSourcesJar()
}
}

externalNativeBuild {
cmake {
path file('CMakeLists.txt')
Expand Down Expand Up @@ -223,12 +229,6 @@ dependencies {
}

afterEvaluate { project ->
task androidSourcesJar(type: Jar) {
classifier = 'sources'
from android.sourceSets.main.java.srcDirs
include '**/*.java'
}

android.libraryVariants.all { variant ->
def name = variant.name.capitalize()
def javaCompileTask = variant.javaCompileProvider.get()
Expand All @@ -237,10 +237,6 @@ afterEvaluate { project ->
from javaCompileTask.destinationDir
}
}

artifacts {
archives androidSourcesJar
}
}

task extractAARHeaders {
Expand Down