Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.3.0-preview2-pshopify5 #32

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add 3.3.0-preview2-pshopify5 #32

merged 1 commit into from
Nov 8, 2023

Conversation

peterzhu2118
Copy link
Member

This backports ruby/ruby#8415.

@casperisfine
Copy link
Contributor

Was this tried in production yet?

k0kubun
k0kubun approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. We seem to have crash reports on SFR, but they are all from 3.3.0-preview2-pshopify2, which has been somehow left in some nodes. The rest of the service running this pshopify5 seems fine.

@peterzhu2118 peterzhu2118 merged commit f7c2d1a into main Nov 8, 2023
3 checks passed
@peterzhu2118 peterzhu2118 deleted the pz-3.3.0-preview2-pshopify5 branch November 8, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperisfine casperisfine casperisfine approved these changes

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzhu2118 @casperisfine @k0kubun