Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename support to the ruby-lsp #57

Closed
vinistock opened this issue Mar 29, 2022 · 1 comment · Fixed by #2626
Closed

Add rename support to the ruby-lsp #57

vinistock opened this issue Mar 29, 2022 · 1 comment · Fixed by #2626
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

vinistock commented Mar 29, 2022

Full support for renaming things, like method names and constants is pretty difficult and should be left for the Sorbet LSP. However, our LSP can support renaming some simple things that don't require complete type checking, like:

  • local variables
  • method/block/lambda arguments

Remember that our LSP doesn't parse every file in the code base, so our renames are limited to the current file.

Documentation: https://microsoft.github.io/language-server-protocol/specification#textDocument_rename

@vinistock vinistock transferred this issue from another repository Apr 8, 2022
@vinistock vinistock mentioned this issue Jul 15, 2022
@andyw8
Copy link
Contributor

andyw8 commented Jan 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants