-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoformat issues with v2.11.1 #482
Comments
I have a branch where I'm adding "integration tests". I'll add these so we can be sure when we've fixed it (either by tweaking config, or fixing correction upstream). |
I think the problem is with cc. @Korri |
Yeah this is a combination of the opening tag already being on a newline originally + the new mapping + us not having a rule that forces the opening element to be on the same line not one that forces a specific indentation Hash values when it's not on the same line as the key. Like all of the following are ok: {
a:
:foo,
b:
:bar,
c:
:bat,
} |
I have updated
rubocop-shopify
to2.11.1
and fixing the layout withbundle exec rubocop -A
produced some weird changes.The code before:
The code after:
There are more extreme examples in this file.
It seems the problem doesn't happen if the opening bracket (or whole entry) is on the same line:
Before
After
The text was updated successfully, but these errors were encountered: