slate watch catches DS_Store with every file change

[t-kelly]

Issue by l-fischer
Thursday Aug 10, 2017 at 15:03 GMT
Originally opened as Shopify/slate-cli#134

---

Every local change while slate is watching, triggers the theme upload of the file successfully, then detects change in .DS_Store, tries to run theme upload on that file and then gets hung there, staying at 0%

Tried adding DS_Store to ignore files and has no effect

ignore_files:
- "*.DS_Store"

[alistairholt]

This has become a problem for me again recently. I'm running 0.12.1 from https://www.npmjs.com/package/@shopify/slate. Example output after running slate watch and making a change:

$ slate watch
[10:46:04] Using gulpfile ~/xxxx/@shopify/slate-tools/lib/gulpfile.js
[10:46:04] Starting 'watch'...
[10:46:04] Starting 'validate:id'...
[10:46:04] Finished 'watch' after 7.11 ms
[10:46:04] Finished 'validate:id' after 9.24 ms
[10:46:04] Starting 'build:config'...
[10:46:04] running task - build:config
[10:46:04] config.yml 1.06 kB
[10:46:04] Finished 'build:config' after 22 ms
[10:46:04] Starting 'watch:assets'...
[10:46:04] Finished 'watch:assets' after 7.05 ms
[10:46:04] Starting 'watch:config'...
[10:46:04] Finished 'watch:config' after 189 μs
[10:46:04] Starting 'watch:svg'...
[10:46:04] Finished 'watch:svg' after 369 μs
[10:46:04] Starting 'watch:css'...
[10:46:04] Finished 'watch:css' after 1.34 ms
[10:46:04] Starting 'watch:js'...
[10:46:04] Finished 'watch:js' after 437 μs
[10:46:04] Starting 'watch:vendor-js'...
[10:46:04] Finished 'watch:vendor-js' after 346 μs
[10:46:04] Starting 'watch:src'...
[10:46:04] Finished 'watch:src' after 24 μs
[10:46:04] Starting 'watch:dist'...
[10:46:04] Finished 'watch:dist' after 284 μs
[10:46:04] Starting 'watch:dist-config'...
[10:46:04] Finished 'watch:dist-config' after 148 μs
[10:46:04] Starting 'deploy:sync-init'...
[10:46:04] Finished 'deploy:sync-init' after 14 ms
[10:46:04] Starting 'deploy:sync-reload'...
[10:46:04] Finished 'deploy:sync-reload' after 8.58 ms
[BS] Proxying: https://xxxx.myshopify.com
[BS] Access URLs:
 ---------------------------------------------------------
       Local: https://localhost:3000/?preview_theme_id=
    External: https://xxxx:3000/?preview_theme_id=
 ---------------------------------------------------------
          UI: http://localhost:3001
 UI External: http://xxxx:3001
 ---------------------------------------------------------
[10:46:45] change in src/styles/modules - change section-article.scss
[10:46:45] running task - build:css
[10:46:45] change in assets - change theme.scss.liquid
[10:46:45] Initiating deploy to development
[10:46:45] change in assets - change utils.scss.liquid
[10:46:45] Initiating deploy to development
[10:46:45] running task [child process] - theme upload
[development]: 2 / 2 [=====================================================] 100 %
[10:46:48] Transfer Complete: File changes successfully synced to store
[BS] Reloading Browsers...
[10:47:12] change in src/templates - change article.liquid
[10:47:12] running task - build:assets
[10:47:12] templates/article.liquid 2.26 kB
[10:47:12] change in templates - change article.liquid
[10:47:12] Initiating deploy to development
[10:47:13] running task [child process] - theme upload
[development]: 1 / 1 [=====================================================] 100 %
[10:47:14] Transfer Complete: File changes successfully synced to store
[BS] Reloading Browsers...
[10:47:34] change in  - change .DS_Store
[10:47:34] Initiating deploy to development
[10:47:34] running task [child process] - theme upload
[development]: 0 / 0 [|]   0 %

After making another change you get this:

[10:51:30] change in src/styles/modules - change section-article.scss
[development]: 0 / 0 [/]   0 %
[10:51:30] change in assets - change theme.scss.liquid
[10:51:30] Initiating deploy to development
[10:51:30] change in assets - change utils.scss.liquid
[development]: 0 / 0 [-]   0 %

And nothing appears to work anymore until I stop the process and start again.

[t-kelly]

@alistairholt Your issue is unrelated to this issue. Please open a new one.

[alistairholt]

@t-kelly Are you sure? Appears to be related to me. I had to modify the source locally to add ignored: /(^|[/\\])\../ from #240 wherever chokidar was being used and I was getting the same lines in the output that were mentioned in the original issue:

[10:47:34] change in - change .DS_Store

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.