Ignore watching dot files in dist/ directory

[t-kelly]

What are you trying to accomplish with this PR?

Fixes #227

Ignores watching .DS_store and any other dot files in the dist/ directory.

For maintainers:

• I have 🎩'd these changes.

[NathanPJF]

I've 🎩'd these changes. Changes in dot-files

Something to note: dot-files are being ignore in the dist/ directory, however, their presence in the src/assets directory will still trigger the build:asset task. This only seems to effect the assets/ directory, other directories will ignore dot-files.

In the screenshot below, I experiment with adding *.txt files and .DS_Store files to the src/assets directory. Note: The .DS_Store files are not being generated by my macOS as I have 10.12.6 installed; I'm am generating them manually with touch .DS_Store

You can see that in case 1 and 3, a new asset triggers a build and then deploy. In case 2 and the last one, a .DS_Store file will trigger build:assets.

Note about hanging spinner

A note about the hanging spinner mentioned in the original issue:

[development]: 0 / 0 [|]  0%

This was previously raised as a bug in Themekit 0.6.12. You can find the original issue here: Shopify/themekit#436

It appears to be addressed in an upcoming release of ThemeKit. Until then, this is a decent patch. Though this might also be fixed to updating @shopify/node-themekit to v0.7.0 and bump @shopify/slate-tools accordingly.

Screenshot of me using node-themekit v0.6.6:

[NathanPJF]

Bumping to v0.7.0 shouldn't be taken lightly though. It introduces theme.lock for remote file checking. Super useful, but we'll want to make sure Slate handles and displays errors correctly for this new tool.

[t-kelly]

Something to note: dot-files are being ignore in the dist/ directory, however, their presence in the src/assets directory will still trigger the build:asset task. This only seems to effect the assets/ directory, other directories will ignore dot-files.

This makes sense since the build/watch process for src/assets/ is to copy any file to dist/assets. Should we ignore all dot files in the src/assets/ folder? I think yes.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.