Add parameters to RTE wrapper methods #284
Conversation
Instead of hard-coding strings in the div-wrapping rte methods, we allow parameters to be passed to improve future scalability and reusability of these methods throughout themes.
Instead of hard-coding strings directly in the div-wrapping rte methods, we allow parameters to be passed to improve scalability and reusability of these methods throughout themes.
|
@maximevaillancourt could you please update the Docs site as well to reflect these changes? https://shopify.github.io/slate/js-examples/#responsive-tables-and-videos Info on how to update Docs: https://github.com/Shopify/slate/blob/master/CONTRIBUTING.md#documentation |
|
@NathanPJF Just updated the docs, see 9718335. |
|
@maximevaillancourt could you please add a parameters table as well as seen in the other methods on the docs site? Screenshot of trap focus table |
This follows the same style used in the Trap Focus section, which explains each parameter used in the `trapFocus` method.
|
@NathanPJF Yup, added in 7b9ddaa. |
docs/js-examples/index.md
Outdated
| | Parameters | Type | Description | | ||
| | :------------------- | :------------ | :------------ | | ||
| | `$tables` | jQuery object | `<table>` elements to be made responsive | | ||
| | `tableWrapperClass` | string | CSS class to apply on the `<div>` that will wrap each targetted `<table>` element | |
There was a problem hiding this comment.
targeted instead of targetted
docs/js-examples/index.md
Outdated
| | `$tables` | jQuery object | `<table>` elements to be made responsive | | ||
| | `tableWrapperClass` | string | CSS class to apply on the `<div>` that will wrap each targetted `<table>` element | | ||
| | `$iframes` | jQuery object | `<iframe>` elements to be made responsive | | ||
| | `iframeWrapperClass` | string | CSS class to apply on the `<div>` that will wrap each targetted `<iframe>` element | |
There was a problem hiding this comment.
targeted instead of targetted
There was a problem hiding this comment.
Great, @maximevaillancourt ! Just two small tweaks and then feel free to merge :)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What are you trying to accomplish with this PR?
Instead of hard-coding selector & class strings directly in the wrapper methods, we allow parameters to be passed in, which improves the scalability and reusability of these methods when creating a new theme.
Checklist