This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Rte helpers fallback class #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kelly
reviewed
Sep 25, 2017
| @@ -15,7 +15,9 @@ slate.rte = { | |||
| * @param {string} options.tableWrapperClass - table wrapper class name | |||
| */ | |||
| wrapTable: function(options) { | |||
| options.$tables.wrap('<div class="' + options.tableWrapperClass + '"></div>'); | |||
| var tableWrapperClass = typeof options.tableWrapperClass !== 'string' ? '' : options.tableWrapperClass; | |||
There was a problem hiding this comment.
If some passes 1234 then would result in a empty string, not '1234'. Is this okay? I'm on the fence.
There was a problem hiding this comment.
That's a fair concern. I can change it back to checking typeof undefined and then outputting the value always as a string.
Regarding the integer class names: Having class names that start with a number requires some work arounds to function in a stylesheet - quick codepen here. But those workarounds exist, so I shouldn't discount it.
This reverts commit 1fc87f3.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fixes #293
To prevent this silent failure/unintended behaviour, I've added a
typeofcheck so only strings may be applied.Checklist
For contributors:
For maintainers: