Prompt user if uploading settings_data.json #439
Conversation
t-kelly
force-pushed
the
prompt-if-settings-data
branch
from
e6f8a22
to
aa98c62
Compare
|
Pull |
packages/slate-sync/index.js
Outdated
| return maybeDeploy; | ||
| } | ||
|
|
||
| function promiseThemekitConfig(files) { |
| const figures = require('figures'); | ||
| const flatten = require('array-flatten'); | ||
| const minimatch = require('minimatch'); | ||
| const wrap = require('word-wrap'); |
| )} It looks like you are about to upload the ${chalk.bold( | ||
| 'settings_data.json', | ||
| )} file.\n` + | ||
| ` This can reset any theme setting customizations you've done in the\n` + |
There was a problem hiding this comment.
I say we remove the contractions and go with "you have" (we're using "you are" above).
| ` Or to disable this prompt, add the following to your slate.config.js file:\n`, | ||
| ); | ||
| console.log( | ||
| ` ${chalk.cyan(`'slate-sync': { promptSkipSettings: false }`)}\n`, |
There was a problem hiding this comment.
Maybe it's me but I find the property name, and the description on line 46, slightly confusing.
First instinct by reading this: it should be promptSkipSettings: true in order to disable the prompt. I understand what you're saying but I think it's the word "skip" that's throwing me off.
We should go with either promptSettings: false or keep as is but rename to skipPromptSettings.
| id: 'promptSkipSettings', | ||
| description: | ||
| 'Enable/disable the prompt to skip uploading settings_data.json', | ||
| default: true, |
There was a problem hiding this comment.
This will need to be updated based on my comment above.
t-kelly
force-pushed
the
prompt-if-settings-data
branch
from
b5f505d
to
2dd31aa
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What are you trying to accomplish with this PR?
Fixes #404
Still TODO
settings_data.jsonin the.envfile.slate.config.js