Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Update liquid-asset-plugin to use tapable.hooks #521

Merged
merged 1 commit into from
May 2, 2018

Conversation

t-kelly
Copy link
Contributor

@t-kelly t-kelly commented May 2, 2018

What are you trying to accomplish with this PR?

Html-webpack-liquid-asset-tags-plugin was using Tapable.plugin() syntax, which is deprecated in Webpack 4. Swap to use Tapable.hooks syntax instead.

@t-kelly t-kelly self-assigned this May 2, 2018
@t-kelly t-kelly changed the base branch from circular-ref to 1.x May 2, 2018 14:36
@t-kelly t-kelly merged commit e8b9a5c into 1.x May 2, 2018
@t-kelly t-kelly deleted the update-asset-tag-to-hook branch May 2, 2018 14:36
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant