This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Pass computed default value to slate.config.js functions #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
With the config updates it is possible to set a config value as a function. This function had access to the SlateConfig instance, allowing you to fetch other config values:
However, one thing that was not possible to do was extend the default value of a config item. If the above config was the default value declared, and you wanted to add another PostCSS plugin while keeping the defaults, you would need to redeclare the default values plus add your own:
This approach requires you to add these libraries as new dependencies in your theme -- not cool.
Now, functions in your
slate.config.js
file have direct access to the default value, allowing you to extend it without needing to rewrite it: