Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Fix liquid styles not uploading to Shopify #883

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Conversation

t-kelly
Copy link
Contributor

@t-kelly t-kelly commented Nov 21, 2018

What are you trying to accomplish with this PR?

Fixes #864, followup #877

Had another look at this and found the source of the problem.. liquidStyle files are not being uploaded to Shopify servers because of some bad filtering on my end. Refining that filtering to exclude liquid styles will make sure its uploaded and you don't get a MIME type error.

Also can see the original scss.liquid file gets output into dist which might cause problems if uploaded to Shopify.

@lock
Copy link

lock bot commented Dec 22, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant