Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Expose request timeout of themekit in .env #968

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Conversation

Liroo
Copy link
Contributor

@Liroo Liroo commented Jan 31, 2019

This PR expose the request timeout optional setting of themekit in the .env of slate.

A .env at the root such as:

SLATE_STORE=***.myshopify.com
SLATE_PASSWORD=***
SLATE_THEME_ID=***
SLATE_IGNORE_FILES=config/settings_data.json
SLATE_TIMEOUT=2m

will set the timeout in config.yml at 2m SLATE_TIMEOUT used by themekit.

This closes #831, fixes #699 and maybe some others I didn't saw.

Checklist

For contributors:

  • I have updated the documentation
  • New .env setting exposing themekit timeout

For maintainers:

  • No major update

This is my first PR on Slate and maybe I'm not aware of everything in the project. I needed to modify the timeout for my own and saw some issues on this.

@ghost ghost added the cla-needed label Jan 31, 2019
@Liroo Liroo changed the title Expose request timeout of themekit in .env of slate theme Expose request timeout of themekit in .env Jan 31, 2019
Copy link
Contributor

@t-kelly t-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Reviewed and tested. Works as expected. Thanks @Liroo!

@ghost ghost removed the cla-needed label Feb 11, 2019
@t-kelly t-kelly merged commit 790f8c0 into Shopify:master Feb 11, 2019
@lock
Copy link

lock bot commented Mar 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants